Skip to content

Commit 7342c48

Browse files
authored
data: Adapt appdata and checks to new flathub standards
* appdata: Remove Purism::form_factor=workstation This is a key=value dict, with two entries one gets an error: E: com.github.tchx84.Flatseal:39: custom-key-duplicated Purism::form_factor A key can only be used once. Apps generally remove the workstation key so the app is still marked as mobile capable. * appdata: Add developer tag developer_name was deprecated in AppStream 1.0, this is the replacement. * appdata: Add launchable Fixes the following error: com.github.tchx84.Flatseal:~: desktop-app-launchable-missing This `desktop-application` component is missing a `desktop-id` launchable tag. This means that this application can not be launched and has no association with its desktop-entry file. It also means no icon data or category information from the desktop-entry file will be available, which will result in this application being ignored entirely. * meson: Switch tests to appstreamcli
1 parent 16af74a commit 7342c48

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

data/com.github.tchx84.Flatseal.appdata.xml.in

+4-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
<!-- TRANSLATORS: Don't translate this text -->
44
<name>Flatseal</name>
55
<id>com.github.tchx84.Flatseal</id>
6+
<launchable type="desktop-id">com.github.tchx84.Flatseal.desktop</launchable>
67
<metadata_license>CC0-1.0</metadata_license>
78
<project_license>GPL-3.0-or-later</project_license>
89
<content_rating type="oars-1.1"/>
@@ -32,10 +33,12 @@
3233
<update_contact>[email protected]</update_contact>
3334
<!-- TRANSLATORS: Don't translate this text -->
3435
<developer_name>Martin Abente Lahaye</developer_name>
36+
<developer id="dev.tchx84">
37+
<name translatable="no">Martin Abente Lahaye</name>
38+
</developer>
3539
<url type="homepage">https://github.com/tchx84/flatseal</url>
3640
<url type="bugtracker">https://github.com/tchx84/flatseal/issues</url>
3741
<custom>
38-
<value key="Purism::form_factor">workstation</value>
3942
<value key="Purism::form_factor">mobile</value>
4043
</custom>
4144
</component>

data/meson.build

+4-4
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@ appstream_file = i18n.merge_file(
2222
install_dir: join_paths(get_option('datadir'), 'appdata')
2323
)
2424

25-
appstream_util = find_program('appstream-util', required: false)
26-
if appstream_util.found()
27-
test('Validate appstream file', appstream_util,
28-
args: ['validate', appstream_file]
25+
appstreamcli = find_program('appstreamcli', required: false)
26+
if appstreamcli.found()
27+
test('Validate appstream file', appstreamcli,
28+
args: ['validate', '--no-net', '--explain', appstream_file]
2929
)
3030
endif
3131

0 commit comments

Comments
 (0)