models: Refine checks for strict filesystem overrides

tchx84 · tchx84 · commit dfc955f3252b · 2024-04-15T14:48:30.000-04:00
Redudant overrides were considered strict overrides, which caused
the same redudant overrides to not be displayed, which is wrong.

e.g., /dir in global and /dir in overrides should be displayed.
diff --git a/src/models/filesystemsOther.js b/src/models/filesystemsOther.js
@@ -103,11 +103,7 @@ var FlatpakFilesystemsOtherModel = GObject.registerClass({
     }
 
     static isStrictlyOverriden(set, value) {
-        const path = value.replace('!', '');
-
-        return (
-            set.has(path) ||
-            set.has(`!${path}`));
+        return set.has(this.negate(value));
     }
 
     static isResetOverride(value) {

Original file line number	Diff line number	Diff line change
`@@ -103,11 +103,7 @@ var FlatpakFilesystemsOtherModel = GObject.registerClass({`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`static isStrictlyOverriden(set, value) {`
`106`		`- const path = value.replace('!', '');`
`107`		`-`
`108`		`- return (`
`109`		`- set.has(path) \|\|`
`110`		- set.has(`!${path}`));
	`106`	`+ return set.has(this.negate(value));`
`111`	`107`	`}`
`112`	`108`
`113`	`109`	`static isResetOverride(value) {`