|
| 1 | +/* eslint-disable @typescript-eslint/naming-convention */ |
| 2 | +import type { INestApplication } from '@nestjs/common'; |
| 3 | +import { FieldKeyType, FieldType } from '@teable/core'; |
| 4 | +import { PrismaService } from '@teable/db-main-prisma'; |
| 5 | +import type { ITableFullVo } from '@teable/openapi'; |
| 6 | +import { ClsService } from 'nestjs-cls'; |
| 7 | +import { RecordCreateService } from '../src/features/record/record-modify/record-create.service'; |
| 8 | +import type { IClsStore } from '../src/types/cls'; |
| 9 | +import { |
| 10 | + createField, |
| 11 | + createRecords, |
| 12 | + createTable, |
| 13 | + initApp, |
| 14 | + permanentDeleteTable, |
| 15 | + getRecords, |
| 16 | + runWithTestUser, |
| 17 | +} from './utils/init-app'; |
| 18 | + |
| 19 | +const sleep = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms)); |
| 20 | + |
| 21 | +const parseSchemaAndTable = (dbTableName: string): [string, string] => { |
| 22 | + const trimQuotes = (value: string) => |
| 23 | + value.startsWith('"') && value.endsWith('"') ? value.slice(1, -1) : value; |
| 24 | + const parts = dbTableName.split('.'); |
| 25 | + return [trimQuotes(parts[0] ?? dbTableName), trimQuotes(parts[1] ?? dbTableName)]; |
| 26 | +}; |
| 27 | + |
| 28 | +describe('Legacy createdTime create compatibility (e2e)', () => { |
| 29 | + let app: INestApplication; |
| 30 | + let prisma: PrismaService; |
| 31 | + let clsService: ClsService<IClsStore>; |
| 32 | + let recordCreateService: RecordCreateService; |
| 33 | + const baseId = globalThis.testConfig.baseId; |
| 34 | + |
| 35 | + beforeAll(async () => { |
| 36 | + app = (await initApp()).app; |
| 37 | + prisma = app.get(PrismaService); |
| 38 | + clsService = app.get<ClsService<IClsStore>>(ClsService); |
| 39 | + recordCreateService = app.get(RecordCreateService); |
| 40 | + }); |
| 41 | + |
| 42 | + afterAll(async () => { |
| 43 | + await app.close(); |
| 44 | + }); |
| 45 | + |
| 46 | + it('fills legacy plain createdTime columns during create so dependent formulas stay correct', async () => { |
| 47 | + const table: ITableFullVo = await createTable(baseId, { |
| 48 | + name: 'legacy_created_time_create', |
| 49 | + fields: [{ name: 'Name', type: FieldType.SingleLineText }], |
| 50 | + records: [], |
| 51 | + }); |
| 52 | + |
| 53 | + try { |
| 54 | + const nameField = table.fields.find((field) => field.name === 'Name'); |
| 55 | + expect(nameField).toBeDefined(); |
| 56 | + |
| 57 | + const createdTimeField = await createField(table.id, { |
| 58 | + name: 'Created Time', |
| 59 | + type: FieldType.CreatedTime, |
| 60 | + }); |
| 61 | + const statusField = await createField(table.id, { |
| 62 | + name: 'Created Status', |
| 63 | + type: FieldType.Formula, |
| 64 | + options: { |
| 65 | + expression: `IF({${createdTimeField.id}}, "ok", "bad")`, |
| 66 | + }, |
| 67 | + }); |
| 68 | + |
| 69 | + const tableMeta = await prisma.tableMeta.findUniqueOrThrow({ |
| 70 | + where: { id: table.id }, |
| 71 | + select: { dbTableName: true }, |
| 72 | + }); |
| 73 | + const [schemaName, rawTableName] = parseSchemaAndTable(tableMeta.dbTableName); |
| 74 | + const quotedTableName = `"${schemaName}"."${rawTableName}"`; |
| 75 | + |
| 76 | + await prisma.$executeRawUnsafe( |
| 77 | + `ALTER TABLE ${quotedTableName} DROP COLUMN "${createdTimeField.dbFieldName}"` |
| 78 | + ); |
| 79 | + await prisma.$executeRawUnsafe( |
| 80 | + `ALTER TABLE ${quotedTableName} ADD COLUMN "${createdTimeField.dbFieldName}" TIMESTAMPTZ` |
| 81 | + ); |
| 82 | + await prisma.$executeRawUnsafe( |
| 83 | + `UPDATE field SET meta = NULL WHERE id = '${createdTimeField.id}'` |
| 84 | + ); |
| 85 | + |
| 86 | + const created = await createRecords(table.id, { |
| 87 | + fieldKeyType: FieldKeyType.Id, |
| 88 | + records: [ |
| 89 | + { |
| 90 | + fields: { |
| 91 | + [nameField!.id]: 'legacy-row', |
| 92 | + }, |
| 93 | + }, |
| 94 | + ], |
| 95 | + }); |
| 96 | + |
| 97 | + const recordId = created.records[0].id; |
| 98 | + let row: |
| 99 | + | { |
| 100 | + created_time: Date | string | null; |
| 101 | + legacy_created_time: Date | string | null; |
| 102 | + created_status: string | null; |
| 103 | + } |
| 104 | + | undefined; |
| 105 | + |
| 106 | + for (let i = 0; i < 20; i++) { |
| 107 | + const rows = await prisma.$queryRawUnsafe< |
| 108 | + { |
| 109 | + created_time: Date | string | null; |
| 110 | + legacy_created_time: Date | string | null; |
| 111 | + created_status: string | null; |
| 112 | + }[] |
| 113 | + >( |
| 114 | + `SELECT "__created_time" AS created_time, |
| 115 | + "${createdTimeField.dbFieldName}" AS legacy_created_time, |
| 116 | + "${statusField.dbFieldName}" AS created_status |
| 117 | + FROM ${quotedTableName} |
| 118 | + WHERE "__id" = '${recordId}'` |
| 119 | + ); |
| 120 | + row = rows[0]; |
| 121 | + if (row?.legacy_created_time && row.created_status === 'ok') { |
| 122 | + break; |
| 123 | + } |
| 124 | + await sleep(200); |
| 125 | + } |
| 126 | + |
| 127 | + expect(row?.created_time).toBeTruthy(); |
| 128 | + expect(row?.legacy_created_time).toBeTruthy(); |
| 129 | + expect(row?.created_status).toBe('ok'); |
| 130 | + expect(new Date(row!.legacy_created_time as string | Date).toISOString()).toEqual( |
| 131 | + new Date(row!.created_time as string | Date).toISOString() |
| 132 | + ); |
| 133 | + } finally { |
| 134 | + await permanentDeleteTable(baseId, table.id); |
| 135 | + } |
| 136 | + }); |
| 137 | + |
| 138 | + it('keeps createRecordsOnlySql working for tables without legacy createdTime columns', async () => { |
| 139 | + const table: ITableFullVo = await createTable(baseId, { |
| 140 | + name: 'create_records_only_sql_plain', |
| 141 | + fields: [{ name: 'Name', type: FieldType.SingleLineText }], |
| 142 | + records: [], |
| 143 | + }); |
| 144 | + |
| 145 | + try { |
| 146 | + const nameField = table.fields.find((field) => field.name === 'Name'); |
| 147 | + expect(nameField).toBeDefined(); |
| 148 | + |
| 149 | + await runWithTestUser(clsService, async () => { |
| 150 | + await recordCreateService.createRecordsOnlySql(table.id, { |
| 151 | + fieldKeyType: FieldKeyType.Id, |
| 152 | + records: [ |
| 153 | + { |
| 154 | + fields: { |
| 155 | + [nameField!.id]: 'plain-row', |
| 156 | + }, |
| 157 | + }, |
| 158 | + ], |
| 159 | + }); |
| 160 | + }); |
| 161 | + |
| 162 | + const result = await getRecords(table.id, { |
| 163 | + fieldKeyType: FieldKeyType.Id, |
| 164 | + }); |
| 165 | + |
| 166 | + expect(result.records).toHaveLength(1); |
| 167 | + expect(result.records[0].fields[nameField!.id]).toBe('plain-row'); |
| 168 | + } finally { |
| 169 | + await permanentDeleteTable(baseId, table.id); |
| 170 | + } |
| 171 | + }); |
| 172 | +}); |
0 commit comments