Merge branch 'CHI-3534-test_lambda' into CHI-3534-set_up_jm_stg_integration_test

stephenhand · stephenhand · commit 22a8d5282f38 · 2025-11-21T17:18:27.000Z
diff --git a/twilio-iac/terraform-modules/aws/default/integration-test-scheduler.tf b/twilio-iac/terraform-modules/aws/default/integration-test-scheduler.tf
@@ -18,7 +18,7 @@ locals {
 
 resource "aws_cloudwatch_event_rule" "integration_test_event_rule" {
   count               = var.enable_integration_tests ? 1 : 0
-  name                = "${local.integration_test_lambda_name}-event-rule"
+  name                = "${local.integration_test_lambda_name}-event-rule-${lower(var.short_helpline)}"
   schedule_expression = var.integration_test_lambda_schedule
 }
 
diff --git a/twilio-iac/terraform-modules/stages/provision/variables.tf b/twilio-iac/terraform-modules/stages/provision/variables.tf
@@ -116,5 +116,6 @@ variable "ui_editable" {
 
 variable "enable_integration_tests" {
   description = "Enables integration tests to run on a schedule for this helpline"
-  type        =  bool
+  type        = bool
+  default     = false
 }

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ locals {`
`18`	`18`
`19`	`19`	`resource "aws_cloudwatch_event_rule" "integration_test_event_rule" {`
`20`	`20`	`count = var.enable_integration_tests ? 1 : 0`
`21`		`- name = "${local.integration_test_lambda_name}-event-rule"`
	`21`	`+ name = "${local.integration_test_lambda_name}-event-rule-${lower(var.short_helpline)}"`
`22`	`22`	`schedule_expression = var.integration_test_lambda_schedule`
`23`	`23`	`}`
`24`	`24`
Original file line number	Diff line number	Diff line change
`@@ -116,5 +116,6 @@ variable "ui_editable" {`
`116`	`116`
`117`	`117`	`variable "enable_integration_tests" {`
`118`	`118`	`description = "Enables integration tests to run on a schedule for this helpline"`
`119`		`- type = bool`
	`119`	`+ type = bool`
	`120`	`+ default = false`
`120`	`121`	`}`