Skip to content

Conversation

@Humairaa127
Copy link
Contributor

Description

Web and FB flow studio widget name standardisation

Checklist

  • Strings are localized
  • Tested for chat contacts
  • Tested for call contacts

Other Related Issues

None

Verification steps

AFTER YOU MERGE

  1. Cut a release tag using the Github workflow. Wait for it to complete and notify in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

},
{
"name": "smsAttributes",
"name": "send_to_queue",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be send_to_queue_sms

},
{
"name": "AdjustAttributes",
"name": "split_AdjustAttributes",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split_adjust_attributes
We use lower case and underscores for naming widgets, except for function names

"add_twilio_auth": false,
"body": "{\"channelSid\": \"{{flow.channel.address}}\", \"message\": \"trigger_pre_survey\", \"studioFlowSid\": \"{{flow.flow_sid}}\", \"language\": \"${flow_vars.bot_language}\", \"botSuffix\": \"pre_survey\", \"triggerType\": \"withUserMessage\", \"releaseType\": \"triggerStudioFlow\", \"releaseFlag\": \"preSurveyComplete\", \"channelType\": \"{{trigger.message.ChannelAttributes.channel_type | downcase}}\", \"isConversation\": \"false\"}",
"url": "${lambda_twilio_account_scoped_url}/channelCapture/captureChannelWithBot"
"url": "${lambda_twilio_account_scoped_url}/channelCapture/f_captureChannelWithBot"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not correct

"content_type": "application/json;charset=utf-8",
"body": "{ \"trigger\": {{trigger | to_json}}}",
"url": "${get_profile_flags_for_identifier_base_url}/getProfileFlagsForIdentifier"
"url": "${get_profile_flags_for_identifier_base_url}/f_getProfileFlagsForIdentifier"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not correct

},
{
"name": "facebookAttributes",
"name": "send_to_queue",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These send_to_queue widgets will need to be updated to make them different to each other

},
{
"name": "send_message_1",
"name": "f_sendMessageAndRunJanitor_no_image",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a widget, so it should me send_message_no_image

},
{
"name": "split_operating_en",
"name": "split_operatingHours_en",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split_operating_hours_en

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants