-
Notifications
You must be signed in to change notification settings - Fork 10
Mw studio widget standardisation #3713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| }, | ||
| { | ||
| "name": "smsAttributes", | ||
| "name": "send_to_queue", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be send_to_queue_sms
| }, | ||
| { | ||
| "name": "AdjustAttributes", | ||
| "name": "split_AdjustAttributes", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
split_adjust_attributes
We use lower case and underscores for naming widgets, except for function names
| "add_twilio_auth": false, | ||
| "body": "{\"channelSid\": \"{{flow.channel.address}}\", \"message\": \"trigger_pre_survey\", \"studioFlowSid\": \"{{flow.flow_sid}}\", \"language\": \"${flow_vars.bot_language}\", \"botSuffix\": \"pre_survey\", \"triggerType\": \"withUserMessage\", \"releaseType\": \"triggerStudioFlow\", \"releaseFlag\": \"preSurveyComplete\", \"channelType\": \"{{trigger.message.ChannelAttributes.channel_type | downcase}}\", \"isConversation\": \"false\"}", | ||
| "url": "${lambda_twilio_account_scoped_url}/channelCapture/captureChannelWithBot" | ||
| "url": "${lambda_twilio_account_scoped_url}/channelCapture/f_captureChannelWithBot" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not correct
| "content_type": "application/json;charset=utf-8", | ||
| "body": "{ \"trigger\": {{trigger | to_json}}}", | ||
| "url": "${get_profile_flags_for_identifier_base_url}/getProfileFlagsForIdentifier" | ||
| "url": "${get_profile_flags_for_identifier_base_url}/f_getProfileFlagsForIdentifier" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not correct
| }, | ||
| { | ||
| "name": "facebookAttributes", | ||
| "name": "send_to_queue", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These send_to_queue widgets will need to be updated to make them different to each other
| }, | ||
| { | ||
| "name": "send_message_1", | ||
| "name": "f_sendMessageAndRunJanitor_no_image", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a widget, so it should me send_message_no_image
| }, | ||
| { | ||
| "name": "split_operating_en", | ||
| "name": "split_operatingHours_en", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
split_operating_hours_en
Description
Web and FB flow studio widget name standardisation
Checklist
Other Related Issues
None
Verification steps
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P