chore: Bulk Skills UX polish [CHI-3547] #3732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenhand
approved these changes
Dec 8, 2025
Collaborator
stephenhand
left a comment
stephenhand
left a comment
There was a problem hiding this comment.
Nothing blocking, just expressing a preference with the dialog props but you can leave as is if you feel strongly this approach is better
| openDialog: boolean; | ||
| closeDialogHeader: string; | ||
| closeDialogContent: string; | ||
| closeDialogHeader: string | React.ReactElement; |
Collaborator
There was a problem hiding this comment.
I'm not such a fan of the string | ReactElement property pattern, I've worked with it before and find it a bit confusing to follow the component chain. If we need to stuff arbitrary elements in this section in some cases I'd rather just always pass an element, even if it is just a template tag, just to make modal configurations more consistent
| closeDialogHeader: string; | ||
| closeDialogContent: string; | ||
| closeDialogHeader: string | React.ReactElement; | ||
| closeDialogContent: string | React.ReactElement; |
Collaborator
There was a problem hiding this comment.
Perhaps we could make this the children property to keep it consistent with the other modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses several UI fixes/polish described in the below linked ticket.
Checklist
Verification steps
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P