fix: [rate soil match] rename to UserDataPush + update types + deprecate old mutation #1909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knipec
changed the title
knipec
changed the title
Exceptions caught at that level are highly unlikely and will now just be caught as an exception for the mutation as a whole
knipec
force-pushed
the
fix/deprecate
branch
from
939bf63 to
732bca2
Compare
knipec
force-pushed
the
fix/deprecate
branch
from
5d9da98 to
a3b488e
Compare
This was referenced Nov 21, 2025
knipec
changed the title
knipec
changed the title
johannesparty
approved these changes
Nov 27, 2025
Contributor
johannesparty
left a comment
johannesparty
left a comment
There was a problem hiding this comment.
ok, finished an easy one!
all looks fine to me.
I did wonder why you no longer needed try/catch.
| result = SoilDataPush.mutate_and_get_payload( | ||
| root, info, soil_data_entries=soil_data_entries | ||
| ) | ||
| soil_data_results = result.results |
Contributor
There was a problem hiding this comment.
Why remove the try/except?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes for Rate Soil Match feature:
Rename
SiteDataPushtoUserDataPushDeprecate update_soil_metadata mutation, in favor of push_user_data mutation. I'd forgotten to mark
update_soil_metadataas deprecated as part of feat: Make new big push mutation and deprecate old one #1900Change the backend type so that the Typescript type is
userRatings: Array<UserRatingEntry>;instead ofuserRatings: Array<Maybe<UserRatingEntry>>;There shouldn't be any time that we have an entry in userRatings that is null.
Change the mutation response in the backend to not have separate error fields for each sub-push (soilData and soilMetadata). Exceptions caught at that level are highly unlikely and will now just be caught as an exception for the mutation as a whole.
Related Issues
To address techmatters/terraso-mobile-client#3107 and techmatters/terraso-mobile-client#3068