Skip to content

Commit 944c75f

Browse files
authored
Merge pull request #1870 from dhensby/claude/awesome-khayyam-8a2dee
feat: test msnodesqlv8 against v2-v5 across supported Node versions
2 parents 9ed830d + 9ed51d2 commit 944c75f

2 files changed

Lines changed: 27 additions & 9 deletions

File tree

.github/workflows/nodejs.yml

Lines changed: 26 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -145,17 +145,35 @@ jobs:
145145
run: npm run test-tedious
146146
- name: Run cli tests
147147
run: npm run test-cli
148-
- name: Install msnodesqlv8
149-
if: ${{ matrix.node != '22.x' && matrix.node != '24.x' }}
148+
# msnodesqlv8 is exercised across its supported major versions. Each major
149+
# is gated to the Node versions it ships prebuilt win32-x64 binaries for —
150+
# a combo without a prebuild falls back to a node-gyp source build, which is
151+
# brittle on the GitHub Windows images (e.g. the VS 2026 rollout on
152+
# windows-2025 that node-gyp cannot detect). Coverage:
153+
# v2: Node 18 v3: Node 18-20 v4: Node 18-24 v5: Node 20-24
154+
- name: Install msnodesqlv8 v2
155+
if: ${{ matrix.node == '18.x' }}
150156
run: npm install --no-save msnodesqlv8@^2
151-
- name: Run msnodesqlv8 tests
152-
if: ${{ matrix.node != '22.x' && matrix.node != '24.x' }}
157+
- name: Run msnodesqlv8 v2 tests
158+
if: ${{ matrix.node == '18.x' }}
153159
run: npm run test-msnodesqlv8
154-
- name: Install msnodesqlv8
155-
if: ${{ matrix.node == '22.x' || matrix.node == '24.x' }}
160+
- name: Install msnodesqlv8 v3
161+
if: ${{ matrix.node == '18.x' || matrix.node == '20.x' }}
162+
run: npm install --no-save msnodesqlv8@^3
163+
- name: Run msnodesqlv8 v3 tests
164+
if: ${{ matrix.node == '18.x' || matrix.node == '20.x' }}
165+
run: npm run test-msnodesqlv8
166+
- name: Install msnodesqlv8 v4
167+
if: ${{ matrix.node == '18.x' || matrix.node == '20.x' || matrix.node == '22.x' || matrix.node == '24.x' }}
156168
run: npm install --no-save msnodesqlv8@^4
157-
- name: Run msnodesqlv8 tests
158-
if: ${{ matrix.node == '22.x' && matrix.node == '24.x' }}
169+
- name: Run msnodesqlv8 v4 tests
170+
if: ${{ matrix.node == '18.x' || matrix.node == '20.x' || matrix.node == '22.x' || matrix.node == '24.x' }}
171+
run: npm run test-msnodesqlv8
172+
- name: Install msnodesqlv8 v5
173+
if: ${{ matrix.node == '20.x' || matrix.node == '22.x' || matrix.node == '24.x' }}
174+
run: npm install --no-save msnodesqlv8@^5
175+
- name: Run msnodesqlv8 v5 tests
176+
if: ${{ matrix.node == '20.x' || matrix.node == '22.x' || matrix.node == '24.x' }}
159177
run: npm run test-msnodesqlv8
160178
release:
161179
name: Release

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
Supported TDS drivers:
88

99
- [Tedious][tedious-url] (pure JavaScript - Windows/macOS/Linux, default)
10-
- [MSNodeSQLv8][msnodesqlv8-url] (Microsoft / Contributors Node V8 Driver for Node.js for SQL Server, v2 native - Windows or Linux/macOS 64 bits only)
10+
- [MSNodeSQLv8][msnodesqlv8-url] (Microsoft / Contributors Node V8 Driver for Node.js for SQL Server, v2-v5 native - Windows or Linux/macOS 64 bits only)
1111

1212
## Installation
1313

0 commit comments

Comments
 (0)