Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate golangci-lint to a container for local run #8486

Open
vdemeester opened this issue Jan 14, 2025 · 0 comments
Open

Migrate golangci-lint to a container for local run #8486

vdemeester opened this issue Jan 14, 2025 · 0 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@vdemeester
Copy link
Member

Now that we have a workflow, we should migrate the way user can run golangci-lint.

Today, we use tools/go.mod to specify the version, but it is already specified in the workflow.
The idea would be the following:

  • Removing golangci-lint import in tools
  • Create a Makefile target that runs a containers (using docker or podman) that runs the version specified in workflow and use that for the golangci/golangci-lint:{version} tag.
@vdemeester vdemeester added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
Tekton Community Roadmap
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vdemeester