Skip to content

Commit 8903ce8

Browse files
chore: include field name on hashmap JS conversion
1 parent 426699e commit 8903ce8

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

packages/core-bridge/src/helpers/try_from_js.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ use neon::{
1111
};
1212
use temporal_sdk_core::Url;
1313

14-
use super::{BridgeError, BridgeResult};
14+
use super::{AppendFieldContext, BridgeError, BridgeResult};
1515

1616
/// Trait for Rust types that can be created from JavaScript values, possibly throwing an error.
1717
pub trait TryFromJs: Sized {
@@ -175,8 +175,9 @@ impl<T: TryFromJs> TryFromJs for HashMap<String, T> {
175175
let mut map = Self::new();
176176
for key_handle in props {
177177
let key = key_handle.to_string(cx)?.value(cx);
178-
let value = obj.get_value(cx, key_handle)?;
179-
map.insert(key, T::try_from_js(cx, value)?);
178+
let js_value = obj.get_value(cx, key_handle)?;
179+
let value = T::try_from_js(cx, js_value).field(&key)?;
180+
map.insert(key, value);
180181
}
181182
Ok(map)
182183
}

0 commit comments

Comments
 (0)