Skip to content

Commit efe9d69

Browse files
committed
formatting & linting
1 parent 8237158 commit efe9d69

File tree

3 files changed

+40
-36
lines changed

3 files changed

+40
-36
lines changed

packages/test/src/test-integration-split-two.ts

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import asyncRetry from 'async-retry';
33
import { v4 as uuid4 } from 'uuid';
44
import * as iface from '@temporalio/proto';
5-
import { WorkflowContinuedAsNewError, WorkflowFailedError, WorkflowHandle } from '@temporalio/client';
5+
import { WorkflowContinuedAsNewError, WorkflowFailedError } from '@temporalio/client';
66
import {
77
ApplicationFailure,
88
defaultPayloadConverter,
@@ -14,18 +14,7 @@ import { searchAttributePayloadConverter } from '@temporalio/common/lib/converte
1414
import { msToNumber, tsToMs } from '@temporalio/common/lib/time';
1515
import { decode as payloadDecode, decodeFromPayloadsAtIndex } from '@temporalio/common/lib/internal-non-workflow';
1616

17-
import {
18-
condition,
19-
defineQuery,
20-
defineSignal,
21-
defineUpdate,
22-
setDefaultQueryHandler,
23-
setDefaultSignalHandler,
24-
setDefaultUpdateHandler,
25-
setHandler,
26-
sleep,
27-
} from '@temporalio/workflow';
28-
import { ReservedPrefixError, reservedPrefixes } from '@temporalio/common/lib/reserved';
17+
import { condition, defineQuery, defineSignal, setDefaultQueryHandler, setHandler, sleep } from '@temporalio/workflow';
2918
import { configurableHelpers, createTestWorkflowBundle } from './helpers-integration';
3019
import * as activities from './activities';
3120
import * as workflows from './workflows';
@@ -773,4 +762,4 @@ test.serial('default query handler is not used if requested query exists', confi
773762
const result = await handle.query('query-handler-type', ...args);
774763
t.deepEqual(result, { name: definedQuery.name, args });
775764
});
776-
});
765+
});

packages/test/src/test-integration-workflows.ts

Lines changed: 36 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import asyncRetry from 'async-retry';
21
import { setTimeout as setTimeoutPromise } from 'timers/promises';
32
import { randomUUID } from 'crypto';
3+
import asyncRetry from 'async-retry';
44
import { ExecutionContext } from 'ava';
55
import { firstValueFrom, Subject } from 'rxjs';
66
import { WorkflowFailedError, WorkflowHandle } from '@temporalio/client';
@@ -9,7 +9,16 @@ import { msToNumber, tsToMs } from '@temporalio/common/lib/time';
99
import { TestWorkflowEnvironment } from '@temporalio/testing';
1010
import { CancelReason } from '@temporalio/worker/lib/activity';
1111
import * as workflow from '@temporalio/workflow';
12-
import { condition, defineQuery, defineSignal, defineUpdate, setDefaultQueryHandler, setDefaultSignalHandler, setDefaultUpdateHandler, setHandler } from '@temporalio/workflow';
12+
import {
13+
condition,
14+
defineQuery,
15+
defineSignal,
16+
defineUpdate,
17+
setDefaultQueryHandler,
18+
setDefaultSignalHandler,
19+
setDefaultUpdateHandler,
20+
setHandler,
21+
} from '@temporalio/workflow';
1322
import { SdkFlags } from '@temporalio/workflow/lib/flags';
1423
import {
1524
ActivityCancellationType,
@@ -20,13 +29,13 @@ import {
2029
TypedSearchAttributes,
2130
WorkflowExecutionAlreadyStartedError,
2231
} from '@temporalio/common';
32+
import { reservedPrefixes } from '@temporalio/common/lib/reserved';
2333
import { signalSchedulingWorkflow } from './activities/helpers';
2434
import { activityStartedSignal } from './workflows/definitions';
2535
import * as workflows from './workflows';
2636
import { Context, createLocalTestEnvironment, helpers, makeTestFunction } from './helpers-integration';
2737
import { overrideSdkInternalFlag } from './mock-internal-flags';
2838
import { asSdkLoggerSink, loadHistory, RUN_TIME_SKIPPING_TESTS, waitUntil } from './helpers';
29-
import { reservedPrefixes } from '@temporalio/common/src/reserved';
3039

3140
const test = makeTestFunction({
3241
workflowsPath: __filename,
@@ -1493,9 +1502,18 @@ test('Workflow failure if define signals/updates/queries with reserved prefixes'
14931502
args: [prefix],
14941503
});
14951504
t.deepEqual(result, [
1496-
{ name: 'ReservedPrefixError', message: `Cannot use signal name: '${prefix}_signal', with reserved prefix: '${prefix}'` },
1497-
{ name: 'ReservedPrefixError', message: `Cannot use update name: '${prefix}_update', with reserved prefix: '${prefix}'` },
1498-
{ name: 'ReservedPrefixError', message: `Cannot use query name: '${prefix}_query', with reserved prefix: '${prefix}'` },
1505+
{
1506+
name: 'ReservedPrefixError',
1507+
message: `Cannot use signal name: '${prefix}_signal', with reserved prefix: '${prefix}'`,
1508+
},
1509+
{
1510+
name: 'ReservedPrefixError',
1511+
message: `Cannot use update name: '${prefix}_update', with reserved prefix: '${prefix}'`,
1512+
},
1513+
{
1514+
name: 'ReservedPrefixError',
1515+
message: `Cannot use query name: '${prefix}_query', with reserved prefix: '${prefix}'`,
1516+
},
14991517
]);
15001518
}
15011519
});
@@ -1518,10 +1536,7 @@ test('Default handlers fail given reserved prefix', async (t) => {
15181536
const { createWorker, startWorkflow } = helpers(t);
15191537
const worker = await createWorker();
15201538

1521-
const assertWftFailure = async (
1522-
handle: WorkflowHandle,
1523-
errMsg: string,
1524-
) => {
1539+
const assertWftFailure = async (handle: WorkflowHandle, errMsg: string) => {
15251540
await asyncRetry(
15261541
async () => {
15271542
const history = await handle.fetchHistory();
@@ -1541,27 +1556,27 @@ test('Default handlers fail given reserved prefix', async (t) => {
15411556

15421557
await worker.runUntil(async () => {
15431558
for (const prefix of reservedPrefixes) {
1544-
15451559
// Reserved query
15461560
let handle = await startWorkflow(workflowWithDefaultHandlers);
15471561
const queryName = `${prefix}_query`;
1548-
await t.throwsAsync(handle.query(queryName, { timeout: 1000 }), {
1549-
// ReservedPrefixError transforms to a QueryNotRegisteredError on the way back from server
1550-
name: 'QueryNotRegisteredError',
1551-
message: `Cannot use query name: '${queryName}', with reserved prefix: '${prefix}'`,
1552-
}, `Query ${queryName} should fail`);
1562+
await t.throwsAsync(
1563+
handle.query(queryName, { timeout: 1000 }),
1564+
{
1565+
// ReservedPrefixError transforms to a QueryNotRegisteredError on the way back from server
1566+
name: 'QueryNotRegisteredError',
1567+
message: `Cannot use query name: '${queryName}', with reserved prefix: '${prefix}'`,
1568+
},
1569+
`Query ${queryName} should fail`
1570+
);
15531571
await handle.terminate();
1554-
15551572

1556-
15571573
// Reserved signal
15581574
handle = await startWorkflow(workflowWithDefaultHandlers);
15591575
const signalName = `${prefix}_signal`;
15601576
await handle.signal(signalName);
15611577
await assertWftFailure(handle, `Cannot use signal name: '${signalName}', with reserved prefix: '${prefix}'`);
15621578
await handle.terminate();
1563-
1564-
1579+
15651580
// Reserved update
15661581
handle = await startWorkflow(workflowWithDefaultHandlers);
15671582
const updateName = `${prefix}_update`;
@@ -1574,4 +1589,4 @@ test('Default handlers fail given reserved prefix', async (t) => {
15741589
await handle.terminate();
15751590
}
15761591
});
1577-
});
1592+
});

packages/worker/src/worker.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ import { workflowLogAttributes } from '@temporalio/workflow/lib/logs';
5757
import { native } from '@temporalio/core-bridge';
5858
import { coresdk, temporal } from '@temporalio/proto';
5959
import { type SinkCall, type WorkflowInfo } from '@temporalio/workflow';
60+
import { throwIfReservedName } from '@temporalio/common/lib/reserved';
6061
import { Activity, CancelReason, activityLogAttributes } from './activity';
6162
import { extractNativeClient, extractReferenceHolders, InternalNativeConnection, NativeConnection } from './connection';
6263
import { ActivityExecuteInput } from './interceptors';
@@ -102,7 +103,6 @@ import {
102103
ShutdownError,
103104
UnexpectedError,
104105
} from './errors';
105-
import { throwIfReservedName } from '@temporalio/common/src/reserved';
106106

107107
export { DataConverter, defaultPayloadConverter };
108108

0 commit comments

Comments
 (0)