Validate NVS storage namespace

Author: dshil

components/ocs_storage/nvs_storage.cpp

@@ -24,8 +24,10 @@ const char* log_tag = "nvs_storage";
 } // namespace
 
 NvsStorage::NvsStorage(const char* ns) {
+    configASSERT(strlen(ns) <= max_namespace_len);
+
     memset(ns_, 0, sizeof(ns_));
-    strncpy(ns_, ns, std::min(bufsize_, strlen(ns)));
+    strncpy(ns_, ns, std::min(max_namespace_len, strlen(ns)));
 }
 
 status::StatusCode NvsStorage::probe(const char* key, size_t& size) {

components/ocs_storage/nvs_storage.h

@@ -21,13 +21,17 @@ namespace storage {
 
 class NvsStorage : public IStorage, public core::NonCopyable<> {
 public:
+    //! Maximum number of symbols for the storage namespace, without NULL character.
+    static constexpr unsigned max_namespace_len = NVS_KEY_NAME_MAX_SIZE - 1;
+
     //! Initialize.
     //!
     //! @params
     //!  - @p ns - NVS namespace.
     //!
     //! @remarks
-    //!  NVS should be initialized.
+    //!  - NVS should be initialized.
+    //!  - namespace length should not exceed @p max_namespace_len.
     explicit NvsStorage(const char* ns);
 
     //! Read data size from the configured namespace.
@@ -53,9 +57,7 @@ class NvsStorage : public IStorage, public core::NonCopyable<> {
 
     status::StatusCode erase_(nvs_handle_t handle, const char* key);
 
-    static const constexpr unsigned bufsize_ = NVS_KEY_NAME_MAX_SIZE - 1;
-
-    char ns_[bufsize_ + 1];
+    char ns_[max_namespace_len + 1];
 };
 
 } // namespace storage