Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve usability of Program Cache handling in Device Operations #18015

Open
ayerofieiev-tt opened this issue Feb 19, 2025 · 0 comments
Open

Comments

@ayerofieiev-tt
Copy link
Member

Developers consistently hit issues with program cache.

  • It is not clear that Device Operation class must provide a hash for {program + compile time args}
  • It is not clear that same Program might get called multiple times if returned hash is the same
  • It is not clear that a proper update function must be provided so that a program could be called with different runtime arguments
  • There is no established testing pattern to check variability in operation arguments and behavior with and without program cache enabled

Keep in mind, there are 2 ways to define a Device Operation today (see topk vs dropout)


Link known failures here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant