More debugging

Author: teracross

.github/workflows/download.yaml

@@ -59,8 +59,15 @@ jobs:
         name: Verify non-empty file was downloaded
         run:  echo "nonEmpty=$(test -s index.html)" >> "$GITHUB_OUTPUT"
 
-      - name: Validate job outputs store properly
-        run: echo "Job output value is ${{steps.verification.outputs.file.nonEmpty}} && true && echo "true"|| echo "false" "
+      - name: Validate job outputs stored properly
+        run: |
+          output=${{steps.verification.outputs.file.nonEmpty}}
+          if [["${output}"]]; then
+            echo "Job output is true. File is not empty."
+          else 
+            echo "Job output is false. File is empty."
+          fi
+
 
       - name: Cache the file - to be used in deployment workflow
         uses: actions/upload-artifact@v4

README.md

@@ -7,6 +7,17 @@ Project utilizing various DevOps tech stacks for web hosting.
 - Google Cloud permissioning for direct access to a single Google Drive file is not so straightforward
 - On Github, secrets stored under Secrets and Variables -> Actions can be accessed by anyone with collaborator access. Secrets and Variables -> Codespaces are encrypted, not passed to forks and are not accessible by all collaborators. 
 - Github Codespaces secrets are NOT accessible in Github Actions Workflows.
+- [Reusable Workflows](https://docs.github.com/en/actions/sharing-automations/reusing-workflows#creating-a-reusable-workflow) as well as more info on [Reusing Workflows](https://docs.github.com/en/actions/sharing-automations/reusing-workflows)
+- [Job Outputs](https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/passing-information-between-jobs)
+Note - most common way to store variables in Github involves using and echo statemnt where a value is stored in variable and then piping the result of that statement into the `$GITHB_OUTPUT` environment variable, ex: 
+```
+echo "MY_VAR=value" >> $GITHUB_OUTPUT
+```
+- Workflow Call and Workflow Dispatch events can be triggered on any branch, HOWEVER Workflow Run will ONLY trigger on the main branch [Github Documentation on Workflow Events]
+(https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_call)
+- BEWARE of the ":" character when doing command-line substitutions
+- Composite actions allow for chaining simple job steps commands together to be executed in a single, reusable step (See [Composite Action](https://docs.github.com/en/actions/sharing-automations/creating-actions/creating-a-composite-action))
+- Nested expressions are NOT supported by Github actions and instead requires the use of the `format` function. For more information on evaluating expresssions in workflows and actions, see [here](https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#format)
 
 
 # references
@@ -25,5 +36,6 @@ In order to test locally, `tflocal` was used in conjunction with localstack to e
 * [ ] add deployment configuration for ansible
 * [X] add github actions CI/CD 
 * [ ] add AWS CodePipline CI/CD
-* ~~[ ] add localstack testing to CI/CD pipeline to verify html page works~~ (using Google Drive direct download to HTML file)
-* [ ] create repository(s) to build Docker images used for downloading the Google Drive file and another image for deploying resources (justification - potential setup/ startup efficiency gain on CI/CD environment initiation)
+* [x] ~~~add localstack testing to CI/CD pipeline to verify html page works~~ (using Google Drive direct download to HTML file)
+* [ ] create repository(s) to build Docker images used for downloading the Google Drive file and another image for deploying resources (justification - potential setup/ startup efficiency gain on CI/CD environment initiation)
+* [ ] Refactor the [download.yaml](.github/workflows/download.yaml) and [deploy.yaml](.github/workflows/deploy.yaml) so that the deploy workflow calls the download workflow instead. (Triggering things from the download workflow initially allowed for easier testing.)