Skip to content

pass fn containing pre req setup to be executed in wrapper#1110

Draft
whoffler wants to merge 1 commit intomainfrom
skipUpgradeTestPrereq
Draft

pass fn containing pre req setup to be executed in wrapper#1110
whoffler wants to merge 1 commit intomainfrom
skipUpgradeTestPrereq

Conversation

@whoffler
Copy link
Contributor

@whoffler whoffler commented Feb 6, 2026

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh
Copy link
Contributor

ocofaigh commented Feb 6, 2026

Would love to see a working example of how this would be consumed in one of our module tests

@whoffler
Copy link
Contributor Author

whoffler commented Feb 6, 2026

this allows us to have the wrapper execute whatever prereq code we want

exploring whether or not we can/should be simpler but stricter and just have user pass existingTerraformOptions and options and let the wrapper take care of the rest

@ocofaigh
Copy link
Contributor

ocofaigh commented Feb 6, 2026

Lets ensure its able to handle the destroy AFTER the main test has executed

@whoffler
Copy link
Contributor Author

whoffler commented Feb 6, 2026

there is already support for this approach in the preapply postapply hooks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants