Call init internally

[lukasz-mitka]

Follow up to #161 since it was done only partially.

    - uses: terraform-linters/setup-tflint@v3
      name: Setup TFLint
      with:
        tflint_version: v0.44.1

    - name: Init TFLint
      run: tflint --init
      env:
        # https://github.com/terraform-linters/tflint/blob/master/docs/user-guide/plugins.md#avoiding-rate-limiting
        GITHUB_TOKEN: ${{ github.token }}

Could become

    - name: Setup TFLint
      uses: terraform-linters/setup-tflint@v4
      with:
        tflint_version: v0.44.1
        init: true

Why?
Simpler usage and complete setup of tflint.

Would need to be off by default and enabled with input param to avoid major bump.

[bendrucker]

Do you have any prior art to support this idea? I can't say I can think of any setup-* actions that run your install step for you, opt-in or not. That is revealing—installing dependencies isn't simple and so these actions are generally focused on setting up the tool, not your project.

[lukasz-mitka]

Do you have any prior art to support this idea?

What do you mean by that?

That is revealing—installing dependencies isn't simple and so these actions are generally focused on setting up the tool, not your project.

I didn't focus on what tflint --init actually does. For me init is just part of the setup. I'd love to not think about it and abstract it behind some setup step. Preferably this one.
But you are right, dependencies aren't typically part of setup-* actions. I guess due to it's name init it fits as a setup step, while it actually is more than that.

Ok to close the discussion if you don't think it's justified. It was just an idea.

[bendrucker]

https://en.wikipedia.org/wiki/Prior_art

Synonyms are "state of the art" and "background art." In other words, what are others doing, are there similar solutions, are there other solutions to this problem?

In software, novelty is generally a bad sign. If you are doing something differently than everyone else and don't have strong conviction about your solution, it likely means your understanding of the problem is incomplete.