Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ignoring files #6

Open
searls opened this issue Jul 29, 2019 · 2 comments
Open

Allow ignoring files #6

searls opened this issue Jul 29, 2019 · 2 comments

Comments

@searls
Copy link
Member

searls commented Jul 29, 2019

Since the catchall final argument to referral is one or more paths (i.e. via shell expansion), then when it comes to ignoring files, I think we need to get creative.

Should that mean accepting multiple --ignore option values? Accepting a quoted string that may have a glob pattern in it that is then expanded via referral and not the shell (e.g. --ignore "**/*_test.rb" to be passed as Dir["**/*_test.rb"] or some such)?

Or should we just forego an option altogether since it'll never be perfect and just have a .referralignore dot file that it'll read in a .gitignorey way. That's what other search tools like ripgrep do (with .rgignore)

cc/ @davemo, since this is one way you might work around codebases that have a few listings that are literally unparseable under 2.6+

@davemo
Copy link

davemo commented Jul 29, 2019

My vote is for the latter, a dotfile for ignores seems to pave the cowpaths from .gitignore and the like and also gives some DX parity with standardrb's use of .standard.yml

@searls
Copy link
Member Author

searls commented Jul 30, 2019

Agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants