Fix up GH actions because YAML is a miserable mark up language #989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jpnorair Want to give this a whirl? I checked that the updated YAML is valid. |
Merged
Contributor
Author
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sooo here's a cool story: YAML that is arbitrarily truncated is still valid YAML. It's possibly one of the worst possible mark up languages ever invented, and it's very finicky about whitespace.
The original file is invalid.
Add spaces on those 4 lines I changed and it's then valid.
I also removed some unnecessary calls that use really strong references in the checkout action. It defaults to whatever the SHA is of what triggered the workflow, so it should "just work" in most cases.