Skip to content

Commit da50b09

Browse files
committed
replace babel-preset-es2015 with babel-preset-env for deprecation
add babel-plugin-transform-object-rest-spread for spread syntax support add test to cover spreading composed into object.
1 parent bc95b73 commit da50b09

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

.babelrc

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
2-
"presets": ["es2015"],
3-
"sourceMaps": true
2+
"presets": ["env"],
3+
"sourceMaps": true,
4+
"plugins": ["transform-object-rest-spread"]
45
}

package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@
3636
"babel-cli": "^6.18.0",
3737
"babel-core": "^6.17.0",
3838
"babel-eslint": "^7.0.0",
39-
"babel-preset-es2015": "^6.16.0",
39+
"babel-plugin-transform-object-rest-spread": "^6.26.0",
40+
"babel-preset-env": "^1.7.0",
4041
"babel-register": "^6.18.0",
4142
"bluebird": "^3.5.0",
4243
"chai": "^3.5.0",

test/unit/helper_spec.js

+7-5
Original file line numberDiff line numberDiff line change
@@ -323,13 +323,15 @@ describe('(unit) src/helper.js', () => {
323323
const comp = base.compose({
324324
r1: { resolve: () => { throw Error('some other error') }, error: () => compositionErr },
325325
r2: { resolve: () => 'r2Result', error: () => compositionErr },
326-
r3: {} // should this throw an exception since it is not a resolver or createResolver params?
326+
r3: {} // should we throw an exception since it is not a resolver or createResolver params?
327327
});
328328

329-
console.log(typeof Function);
330-
expect(comp.r1).to.be.a(typeof Function);
331-
expect(comp.r2).to.be.a(typeof Function);
332-
expect(comp.r3).to.be.a(typeof Function);
329+
const composed = { r0: () => {}, ...comp };
330+
331+
expect(composed.r0).to.be.a(typeof Function);
332+
expect(composed.r1).to.be.a(typeof Function);
333+
expect(composed.r2).to.be.a(typeof Function);
334+
expect(composed.r3).to.be.a(typeof Function);
333335

334336
});
335337

0 commit comments

Comments
 (0)