Fix order of converting user #147
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only convert the user from Symfony to League when no response is set on the event. As conversion doesn't / shouldn't have any side effects and the AuthorizationRequest isn't stored either (when a response is set) this should be safe. This helps in those cases where no user is logged in / resolved, but one of the listeners sets a redirect. Otherwise the converter will be called with a null value and has to return a proper value (can't be null) for no obvious reason except to satisfy the interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only convert the user from Symfony to League when no response is set on the event. As conversion doesn't / shouldn't have any side effects and the AuthorizationRequest isn't stored either (when a response is set) this should be safe.
This helps in those cases where no user is logged in / resolved, but one of the listeners sets a redirect. Otherwise the converter will be called with a null value and has to return a proper value (can't be null) for no obvious reason except to satisfy the interface.