Skip to content

Commit cc9013b

Browse files
committed
Fix offset issue for unapproved students (#57)
1 parent 2e9aaa3 commit cc9013b

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

app/src/main/java/tk/therealsuji/vtopchennai/services/VTOPService.java

+7-5
Original file line numberDiff line numberDiff line change
@@ -801,7 +801,6 @@ private void downloadCourses() {
801801
" }" +
802802
" var table = doc.getElementById('studentDetailsList').getElementsByTagName('table')[0];" +
803803
" var headings = table.getElementsByTagName('th');" +
804-
" var offset = headings[0].innerText.toLowerCase().includes('invoice') ? -1 : 0;" +
805804
" var courseIndex, creditsIndex, slotVenueIndex, facultyIndex;" +
806805
" for(var i = 0; i < headings.length; ++i) {" +
807806
" var heading = headings[i].innerText.toLowerCase();" +
@@ -816,6 +815,9 @@ private void downloadCourses() {
816815
" }" +
817816
" }" +
818817
" var cells = table.getElementsByTagName('td');" +
818+
" var headingOffset = headings[0].innerText.toLowerCase().includes('invoice') ? -1 : 0;" +
819+
" var cellOffset = cells[0].innerText.toLowerCase().includes('invoice') ? 1 : 0;" +
820+
" var offset = headingOffset + cellOffset;" +
819821
" while (courseIndex < cells.length && creditsIndex < cells.length && slotVenueIndex < cells.length && facultyIndex < cells.length) {" +
820822
" var course = {};" +
821823
" var rawCourse = cells[courseIndex + offset].innerText.replace(/\\t/g,'').replace(/\\n/g,' ');" +
@@ -831,10 +833,10 @@ private void downloadCourses() {
831833
" course.venue = rawSlotVenue.slice(1, rawSlotVenue.length).join(' - ').trim();" +
832834
" course.faculty = rawFaculty[0].trim();" +
833835
" response.courses.push(course);" +
834-
" courseIndex += headings.length + offset;" +
835-
" creditsIndex += headings.length + offset;" +
836-
" slotVenueIndex += headings.length + offset;" +
837-
" facultyIndex += headings.length + offset;" +
836+
" courseIndex += headings.length + headingOffset;" +
837+
" creditsIndex += headings.length + headingOffset;" +
838+
" slotVenueIndex += headings.length + headingOffset;" +
839+
" facultyIndex += headings.length + headingOffset;" +
838840
" }" +
839841
" }" +
840842
"});" +

0 commit comments

Comments
 (0)