ASoC: SOF: ipc4-topology: Improve playback dai copier in/out format selection

The dai copier configuration for playback and capture needs to be separated
because it is not correct to configure the dai copier as part of the input
format selection for both direction.
The input format is the dai format for capture, but it is not for playback,
for playback the dai format is on the output side.

Currently we configure and adjust the params based on the DAI supported
formats when configuring the input side of the copier but right after the
format has been adjusted we reset it for playback and loose this
information.

When using a nocodec passthrough topology (which is a bug) we have  SSP
blobs supporting 32bit only, copier supporting 16/24/32 bit then on
playback the dai and copier will be incorrectly configured:
host.copier.in: S16_LE
host.copier.out: S16_LE
dai.copier.in: S16_LE
SSP.blob: S32_LE (we only have S32_LE blobs)
dai.copier.out: S16_LE (the dai constraint is ignored)

To handle such case the handling of capture and playback streams must be
changed:
The input format (no changes to previous implementation):
for playback it is the pipeline_params
for capture it is the adjusted fe_params

The output format (no change for capture direction):
for playback it is the adjusted fe_params
for capture it is the fe_params

with this change path format configuration will be correct:
host.copier.in: S16_LE
host.copier.out: S16_LE
dai.copier.in: S16_LE
SSP.blob: S32_LE (we only have S32_LE blobs)
dai.copier.out: S32_LE

Signed-off-by: Peter Ujfalusi <[email protected]>

Author: ujfalusi

sound/soc/sof/ipc4-topology.c

@@ -2009,28 +2009,32 @@ sof_ipc4_prepare_copier_module(struct snd_sof_widget *swidget,
 		copier_data = &ipc4_copier->data;
 		available_fmt = &ipc4_copier->available_fmt;
 
-		/*
-		 * Use the fe_params as a base for the copier configuration.
-		 * The ref_params might get updated to reflect what format is
-		 * supported by the copier on the DAI side.
-		 *
-		 * In case of capture the ref_params returned will be used to
-		 * find the input configuration of the copier.
-		 */
-		ref_params = kmemdup(fe_params, sizeof(*ref_params), GFP_KERNEL);
-		if (!ref_params)
-			return -ENOMEM;
-
-		ret = sof_ipc4_prepare_dai_copier(sdev, dai, ref_params, dir);
-		if (ret < 0)
-			return ret;
+		if (dir == SNDRV_PCM_STREAM_PLAYBACK) {
+			/*
+			 * For playback the pipeline_params needs to be used to
+			 * find the input configuration of the copier.
+			 */
+			ref_params = kmemdup(pipeline_params, sizeof(*ref_params),
+					     GFP_KERNEL);
+			if (!ref_params)
+				return -ENOMEM;
+		} else {
+			/*
+			 * For capture the adjusted fe_params needs to be used
+			 * to find the input configuration of the copier.
+			 *
+			 * The params might be updated in
+			 * sof_ipc4_prepare_dai_copier() to reflect the supported
+			 * input formats by the copier/dai.
+			 */
+			ref_params = kmemdup(fe_params, sizeof(*ref_params), GFP_KERNEL);
+			if (!ref_params)
+				return -ENOMEM;
 
-		/*
-		 * For playback the pipeline_params needs to be used to find the
-		 * input configuration of the copier.
-		 */
-		if (dir == SNDRV_PCM_STREAM_PLAYBACK)
-			memcpy(ref_params, pipeline_params, sizeof(*ref_params));
+			ret = sof_ipc4_prepare_dai_copier(sdev, dai, ref_params, dir);
+			if (ret < 0)
+				return ret;
+		}
 
 		break;
 	}
@@ -2084,10 +2088,28 @@ sof_ipc4_prepare_copier_module(struct snd_sof_widget *swidget,
 	}
 	case snd_soc_dapm_aif_out:
 	case snd_soc_dapm_dai_in:
-		out_ref_rate = params_rate(fe_params);
-		out_ref_channels = params_channels(fe_params);
+		/*
+		 * For capture the fe_params needs to be used to find the output
+		 * configuration of the copier.
+		 *
+		 * For playback the adjusted fe_params needs to be used
+		 * to find the output configuration of the copier.
+		 *
+		 * The params might be updated in
+		 * sof_ipc4_prepare_dai_copier() to reflect the supported
+		 * output formats by the copier/dai.
+		 */
+		memcpy(ref_params, fe_params, sizeof(*ref_params));
+		if (dir == SNDRV_PCM_STREAM_PLAYBACK) {
+			ret = sof_ipc4_prepare_dai_copier(sdev, dai, ref_params, dir);
+			if (ret < 0)
+				return ret;
+		}
+
+		out_ref_rate = params_rate(ref_params);
+		out_ref_channels = params_channels(ref_params);
 		if (!single_output_bitdepth) {
-			out_ref_valid_bits = sof_ipc4_get_valid_bits(sdev, fe_params);
+			out_ref_valid_bits = sof_ipc4_get_valid_bits(sdev, ref_params);
 			if (out_ref_valid_bits < 0)
 				return out_ref_valid_bits;
 		}