Skip to content

Commit 906de9b

Browse files
authoredAug 24, 2022
Update dependencies for SignatureMintERC1155; Correct function mutability (#223)
* update dependencies for SignatureMintERC1155 * change mutability to view
1 parent 66b6fbf commit 906de9b

18 files changed

+18
-20
lines changed
 

‎contracts/base/ERC721Multiwrap.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ contract ERC721Multiwrap is Multicall, TokenStore, SoulboundERC721A, ERC721A, Co
203203
}
204204

205205
/// @dev Returns whether transfers can be restricted in a given execution context.
206-
function _canRestrictTransfers() internal virtual override returns (bool) {
206+
function _canRestrictTransfers() internal view virtual override returns (bool) {
207207
return msg.sender == owner();
208208
}
209209

‎contracts/extension/ContractMetadata.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,5 +39,5 @@ abstract contract ContractMetadata is IContractMetadata {
3939
}
4040

4141
/// @dev Returns whether contract metadata can be set in the given execution context.
42-
function _canSetContractURI() internal virtual returns (bool);
42+
function _canSetContractURI() internal view virtual returns (bool);
4343
}

‎contracts/extension/Drop.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -316,5 +316,5 @@ abstract contract Drop is IDrop {
316316
returns (uint256 startTokenId);
317317

318318
/// @dev Determine what wallet can update claim conditions
319-
function _canSetClaimConditions() internal virtual returns (bool);
319+
function _canSetClaimConditions() internal view virtual returns (bool);
320320
}

‎contracts/extension/DropSinglePhase.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -252,5 +252,5 @@ abstract contract DropSinglePhase is IDropSinglePhase {
252252
virtual
253253
returns (uint256 startTokenId);
254254

255-
function _canSetClaimConditions() internal virtual returns (bool);
255+
function _canSetClaimConditions() internal view virtual returns (bool);
256256
}

‎contracts/extension/DropSinglePhase1155.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -272,5 +272,5 @@ abstract contract DropSinglePhase1155 is IDropSinglePhase1155 {
272272
uint256 _quantityBeingClaimed
273273
) internal virtual;
274274

275-
function _canSetClaimConditions() internal virtual returns (bool);
275+
function _canSetClaimConditions() internal view virtual returns (bool);
276276
}

‎contracts/extension/Ownable.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,5 +49,5 @@ abstract contract Ownable is IOwnable {
4949
}
5050

5151
/// @dev Returns whether owner can be set in the given execution context.
52-
function _canSetOwner() internal virtual returns (bool);
52+
function _canSetOwner() internal view virtual returns (bool);
5353
}

‎contracts/extension/PlatformFee.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,5 +51,5 @@ abstract contract PlatformFee is IPlatformFee {
5151
}
5252

5353
/// @dev Returns whether platform fee info can be set in the given execution context.
54-
function _canSetPlatformFeeInfo() internal virtual returns (bool);
54+
function _canSetPlatformFeeInfo() internal view virtual returns (bool);
5555
}

‎contracts/extension/PrimarySale.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,5 +41,5 @@ abstract contract PrimarySale is IPrimarySale {
4141
}
4242

4343
/// @dev Returns whether primary sale recipient can be set in the given execution context.
44-
function _canSetPrimarySaleRecipient() internal virtual returns (bool);
44+
function _canSetPrimarySaleRecipient() internal view virtual returns (bool);
4545
}

‎contracts/extension/Royalty.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -130,5 +130,5 @@ abstract contract Royalty is IRoyalty {
130130
}
131131

132132
/// @dev Returns whether royalty info can be set in the given execution context.
133-
function _canSetRoyaltyInfo() internal virtual returns (bool);
133+
function _canSetRoyaltyInfo() internal view virtual returns (bool);
134134
}

‎contracts/extension/SignatureMintERC1155.sol

+1-3
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,7 @@
22
pragma solidity ^0.8.0;
33

44
import "./interface/ISignatureMintERC1155.sol";
5-
6-
import "@openzeppelin/contracts/utils/cryptography/ECDSA.sol";
7-
import "@openzeppelin/contracts/utils/cryptography/draft-EIP712.sol";
5+
import "../openzeppelin-presets/utils/cryptography/EIP712.sol";
86

97
abstract contract SignatureMintERC1155 is EIP712, ISignatureMintERC1155 {
108
using ECDSA for bytes32;

‎contracts/extension/SoulboundERC721A.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ abstract contract SoulboundERC721A is PermissionsEnumerable {
3535
}
3636

3737
/// @dev Returns whether transfers can be restricted in a given execution context.
38-
function _canRestrictTransfers() internal virtual returns (bool);
38+
function _canRestrictTransfers() internal view virtual returns (bool);
3939

4040
/// @dev See {ERC721A-_beforeTokenTransfers}.
4141
function _beforeTokenTransfers(

‎src/test/sdk/extension/ContractMetadata.t.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ contract MyContractMetadata is ContractMetadata {
1313
condition = _condition;
1414
}
1515

16-
function _canSetContractURI() internal override returns (bool) {
16+
function _canSetContractURI() internal view override returns (bool) {
1717
return condition;
1818
}
1919
}

‎src/test/sdk/extension/DropSinglePhase.t.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ contract MyDropSinglePhase is DropSinglePhase {
1313
condition = _condition;
1414
}
1515

16-
function _canSetClaimConditions() internal override returns (bool) {
16+
function _canSetClaimConditions() internal view override returns (bool) {
1717
return condition;
1818
}
1919

‎src/test/sdk/extension/DropSinglePhase1155.t.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ contract MyDropSinglePhase1155 is DropSinglePhase1155 {
1313
condition = _condition;
1414
}
1515

16-
function _canSetClaimConditions() internal override returns (bool) {
16+
function _canSetClaimConditions() internal view override returns (bool) {
1717
return condition;
1818
}
1919

‎src/test/sdk/extension/Ownable.t.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ contract MyOwnable is Ownable {
1313
condition = _condition;
1414
}
1515

16-
function _canSetOwner() internal override returns (bool) {
16+
function _canSetOwner() internal view override returns (bool) {
1717
return condition;
1818
}
1919
}

‎src/test/sdk/extension/PlatformFee.t.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ contract MyPlatformFee is PlatformFee {
1313
condition = _condition;
1414
}
1515

16-
function _canSetPlatformFeeInfo() internal override returns (bool) {
16+
function _canSetPlatformFeeInfo() internal view override returns (bool) {
1717
return condition;
1818
}
1919
}

‎src/test/sdk/extension/PrimarySale.t.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ contract MyPrimarySale is PrimarySale {
1313
condition = _condition;
1414
}
1515

16-
function _canSetPrimarySaleRecipient() internal override returns (bool) {
16+
function _canSetPrimarySaleRecipient() internal view override returns (bool) {
1717
return condition;
1818
}
1919
}

‎src/test/sdk/extension/Royalty.t.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ contract MyRoyalty is Royalty {
1313
condition = _condition;
1414
}
1515

16-
function _canSetRoyaltyInfo() internal override returns (bool) {
16+
function _canSetRoyaltyInfo() internal view override returns (bool) {
1717
return condition;
1818
}
1919

0 commit comments

Comments
 (0)
Please sign in to comment.