Skip to content

Commit e85528e

Browse files
authoredMar 14, 2025··
Fix function conflict in marketplace extensions (#682)
1 parent 3bffd0e commit e85528e

File tree

10 files changed

+12
-10
lines changed

10 files changed

+12
-10
lines changed
 

‎contracts/prebuilts/marketplace/direct-listings/DirectListingsLogic.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ contract DirectListingsLogic is IDirectListings, ReentrancyGuard, ERC2771Context
3636
/// @dev The max bps of the contract. So, 10_000 == 100 %
3737
uint64 private constant MAX_BPS = 10_000;
3838

39-
address public constant DEFAULT_FEE_RECIPIENT = 0x1Af20C6B23373350aD464700B5965CE4B0D2aD94;
39+
address private constant DEFAULT_FEE_RECIPIENT = 0x1Af20C6B23373350aD464700B5965CE4B0D2aD94;
4040
uint16 private constant DEFAULT_FEE_BPS = 100;
4141

4242
/// @dev The address of the native token wrapper contract.

‎contracts/prebuilts/marketplace/english-auctions/EnglishAuctionsLogic.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ contract EnglishAuctionsLogic is IEnglishAuctions, ReentrancyGuard, ERC2771Conte
3838
/// @dev The max bps of the contract. So, 10_000 == 100 %
3939
uint64 private constant MAX_BPS = 10_000;
4040

41-
address public constant DEFAULT_FEE_RECIPIENT = 0x1Af20C6B23373350aD464700B5965CE4B0D2aD94;
41+
address private constant DEFAULT_FEE_RECIPIENT = 0x1Af20C6B23373350aD464700B5965CE4B0D2aD94;
4242
uint16 private constant DEFAULT_FEE_BPS = 100;
4343

4444
/// @dev The address of the native token wrapper contract.

‎contracts/prebuilts/marketplace/entrypoint/MarketplaceV3.sol

+2
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ contract MarketplaceV3 is
5858
/// @dev The address of the native token wrapper contract.
5959
address private immutable nativeTokenWrapper;
6060

61+
address public constant DEFAULT_FEE_RECIPIENT = 0x1Af20C6B23373350aD464700B5965CE4B0D2aD94;
62+
6163
/*///////////////////////////////////////////////////////////////
6264
Constructor + initializer logic
6365
//////////////////////////////////////////////////////////////*/

‎contracts/prebuilts/marketplace/offers/OffersLogic.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ contract OffersLogic is IOffers, ReentrancyGuard, ERC2771ContextConsumer {
3535
/// @dev The max bps of the contract. So, 10_000 == 100 %
3636
uint64 private constant MAX_BPS = 10_000;
3737

38-
address public constant DEFAULT_FEE_RECIPIENT = 0x1Af20C6B23373350aD464700B5965CE4B0D2aD94;
38+
address private constant DEFAULT_FEE_RECIPIENT = 0x1Af20C6B23373350aD464700B5965CE4B0D2aD94;
3939
uint16 private constant DEFAULT_FEE_BPS = 100;
4040

4141
/*///////////////////////////////////////////////////////////////

‎src/test/marketplace/DirectListings.t.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ contract MarketplaceDirectListingsTest is BaseTest, IExtension {
7474

7575
// Deploy `DirectListings`
7676
address directListings = address(new DirectListingsLogic(address(weth)));
77-
defaultFeeRecipient = DirectListingsLogic(directListings).DEFAULT_FEE_RECIPIENT();
77+
defaultFeeRecipient = 0x1Af20C6B23373350aD464700B5965CE4B0D2aD94;
7878
vm.label(directListings, "DirectListings_Extension");
7979

8080
// Extension: DirectListingsLogic

‎src/test/marketplace/EnglishAuctions.t.sol

+2-2
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ contract MarketplaceEnglishAuctionsTest is BaseTest, IExtension {
7575

7676
// Deploy `EnglishAuctions`
7777
address englishAuctions = address(new EnglishAuctionsLogic(address(weth)));
78-
defaultFeeRecipient = EnglishAuctionsLogic(englishAuctions).DEFAULT_FEE_RECIPIENT();
78+
defaultFeeRecipient = 0x1Af20C6B23373350aD464700B5965CE4B0D2aD94;
7979
vm.label(englishAuctions, "EnglishAuctions_Extension");
8080

8181
// Extension: EnglishAuctionsLogic
@@ -2171,7 +2171,7 @@ contract BreitwieserTheCreator is BaseTest, IERC721Receiver, IExtension {
21712171

21722172
// Deploy `EnglishAuctions`
21732173
address englishAuctions = address(new EnglishAuctionsLogic(address(weth)));
2174-
defaultFeeRecipient = EnglishAuctionsLogic(englishAuctions).DEFAULT_FEE_RECIPIENT();
2174+
defaultFeeRecipient = 0x1Af20C6B23373350aD464700B5965CE4B0D2aD94;
21752175
vm.label(englishAuctions, "EnglishAuctions_Extension");
21762176

21772177
// Extension: EnglishAuctionsLogic

‎src/test/marketplace/Offers.t.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ contract MarketplaceOffersTest is BaseTest, IExtension {
7474

7575
// Deploy `Offers`
7676
address offers = address(new OffersLogic());
77-
defaultFeeRecipient = OffersLogic(offers).DEFAULT_FEE_RECIPIENT();
77+
defaultFeeRecipient = 0x1Af20C6B23373350aD464700B5965CE4B0D2aD94;
7878
vm.label(offers, "Offers_Extension");
7979

8080
// Extension: OffersLogic

‎src/test/marketplace/direct-listings/_payout/_payout.t.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ contract PayoutTest is BaseTest, IExtension {
9797

9898
// Deploy `DirectListings`
9999
address directListings = address(new DirectListingsLogic(address(weth)));
100-
defaultFeeRecipient = DirectListingsLogic(directListings).DEFAULT_FEE_RECIPIENT();
100+
defaultFeeRecipient = 0x1Af20C6B23373350aD464700B5965CE4B0D2aD94;
101101
vm.label(directListings, "DirectListings_Extension");
102102

103103
// Extension: DirectListingsLogic

‎src/test/marketplace/english-auctions/_payout/_payout.t.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ contract EnglishAuctionsPayoutTest is BaseTest, IExtension {
149149

150150
// Deploy `EnglishAuctions`
151151
address englishAuctions = address(new EnglishAuctionsLogic(address(weth)));
152-
defaultFeeRecipient = EnglishAuctionsLogic(englishAuctions).DEFAULT_FEE_RECIPIENT();
152+
defaultFeeRecipient = 0x1Af20C6B23373350aD464700B5965CE4B0D2aD94;
153153
vm.label(englishAuctions, "EnglishAuctions_Extension");
154154

155155
// Extension: EnglishAuctionsLogic

‎src/test/marketplace/english-auctions/collectAuctionPayout/collectAuctionPayout.t.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ contract CollectAuctionPayoutTest is BaseTest, IExtension {
144144

145145
// Deploy `EnglishAuctions`
146146
address englishAuctions = address(new EnglishAuctionsLogic(address(weth)));
147-
defaultFeeRecipient = EnglishAuctionsLogic(englishAuctions).DEFAULT_FEE_RECIPIENT();
147+
defaultFeeRecipient = 0x1Af20C6B23373350aD464700B5965CE4B0D2aD94;
148148
vm.label(englishAuctions, "EnglishAuctions_Extension");
149149

150150
// Extension: EnglishAuctionsLogic

0 commit comments

Comments
 (0)
Please sign in to comment.