Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query regarding face pose axis visualisation #21

Open
shubhamwagh opened this issue May 25, 2022 · 3 comments
Open

Query regarding face pose axis visualisation #21

shubhamwagh opened this issue May 25, 2022 · 3 comments

Comments

@shubhamwagh
Copy link

shubhamwagh commented May 25, 2022

I see that to construct rotation matrix(R) from yaw, pitch and roll angle values, you use zyx order i.e Rz * Ry * Rx,
where Rz is rotation about z-axis, Ry is rotation about the y-axis, and Rx is rotation about the x-axis.

But for visualisation, it looks like the order you use is xyz i.e Rx * Ry * Rz and then use column vectors of this resulting matrix as axis coordinates (https://github.com/thohemp/6DRepNet/blob/master/utils.py#L54). May I know why this is done? Am I missing something?

Thanks.

@thohemp
Copy link
Owner

thohemp commented Jun 3, 2022

The order of the rotation matrix is actually XYZ: https://github.com/thohemp/6DRepNet/blob/master/utils.py#L207

@chwoong
Copy link

chwoong commented Aug 12, 2022

Dear @thohemp
Thank you very much for providing a great demo :)
It was very helpful.

https://github.com/thohemp/6DRepNet/blob/master/utils.py#L207
I think you got the rotation matrix using pitch-yaw-roll order.
However, https://github.com/thohemp/6DRepNet/blob/master/utils.py#L54
It looks like roll-yaw-pitch order. (see how x3 and y3 are defined. They are independent on roll).

Did I think something wrong? (@shubhamwagh)
Thank you.

@shubhamwagh
Copy link
Author

@chwoong yes exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants