Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding more CI tests? #10

Open
MaxPeal opened this issue May 26, 2020 · 2 comments
Open

adding more CI tests? #10

MaxPeal opened this issue May 26, 2020 · 2 comments

Comments

@MaxPeal
Copy link
Contributor

MaxPeal commented May 26, 2020

i like to add some CI tests,
like boot some bsd with a different arch

can you give me a hint about the usage of docker-library/bashbrew?

@tianon
Copy link
Owner

tianon commented May 27, 2020

I would love to have some more tests here! This is something I'd considered adding, but hadn't had a chance to do myself yet.

I've done some changes to add a custom test-config.sh over in https://github.com/tianon/dockerfiles, but so far haven't added any custom tests over there. I think a similar approach should work here; https://github.com/docker-library/official-images/tree/master/test is the test suite / wrapper we're currently hooking into.

If we add a test-config.sh and adjust run.sh to include it in --config (like in https://github.com/tianon/dockerfiles), then add a tests directory with a qemu-basics test of some kind, it should "just work" for the most part.

I've definitely got reservations about testing against BSD because my experience with BSD is extremely limited so if anything goes wrong with the tests, my ability to debug/understand what's happening is going to be very limited, but I think there are probably a few minimal Linux-based distributions that should be reasonable to test against.

I'd also like to prioritize testing with KVM more than non-KVM (given it will be more performant and also more likely to have issues).

Even just getting a simple initial run.sh for a qemu-basics test would be a good start!

@tianon
Copy link
Owner

tianon commented Mar 19, 2021

The images at https://people.debian.org/~gio/dqib/ are a bit on the large size, but might be OK for some basic testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants