Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove useless commit messages when merge PR #36

Open
zhouqiang-cl opened this issue Jun 29, 2020 · 7 comments
Open

remove useless commit messages when merge PR #36

zhouqiang-cl opened this issue Jun 29, 2020 · 7 comments
Assignees
@zhouqiang-cl

Comments

@zhouqiang-cl
Copy link
Contributor

zhouqiang-cl commented Jun 29, 2020 •
edited
Loading

like pingcap/tidb@59cb7e1, it is too long
/cc @jackysp
@zhouqiang-cl
Copy link
Contributor Author

/assigne @zhouqiang-cl

@you06
Copy link
Contributor

you06 commented Jun 29, 2020

/assign

@ti-srebot
Copy link
Collaborator

Assign failed.

@zhouqiang-cl
Copy link
Contributor Author

/assign

@zhouqiang-cl
Copy link
Contributor Author

great command. /cc @you06

@you06
Copy link
Contributor

you06 commented Jun 30, 2020

@zhouqiang-cl I'm afraid that github change the default commit message when we pass an empty string(actually the bot always do this if the signed-off-message is false). I've checked out the latest commits in TiKV which turned signed-off-message on, there are not dirty commit messages.

So there can be a hotfix, turn on signed-off-message for TiDB.

https://github.com/pingcap-incubator/cherry-bot/blob/3c0cdf3ff337077de75323b533cbfea91caba2f4/config/config.go#L97

@zhouqiang-cl
Copy link
Contributor Author

It works !!!

@zhouqiang-cl zhouqiang-cl reopened this Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhouqiang-cl zhouqiang-cl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@you06 @zhouqiang-cl @ti-srebot