clinic sites cleanups requested in code review

BACK-3632

Author: ewollesen

reference/clinic.v1.yaml

@@ -2664,8 +2664,7 @@ components:
       in: path
       required: true
       schema:
-        type: string
-        pattern: '^[a-f0-9]{24}$'
+        $ref: ./clinic/models/siteId.v1.yaml
     userId:
       name: userId
       in: path

reference/clinic/models/site.v1.yaml

@@ -3,20 +3,9 @@ title: Site
 description: "A clinic's physical or logical location."
 properties:
   id:
-    title: Object Id
-    type: string
-    x-go-type-skip-optional-pointer: true
-    description: String representation of a resource id
-    minLength: 24
-    maxLength: 24
-    pattern: '^[a-f0-9]{24}$'
+    $ref: ./siteId.v1.yaml
   name:
-    type: string
-    x-go-type-skip-optional-pointer: true
-    description: The site description.
-    minLength: 1
-    maxLength: 200
-    pattern: '^[[:graph:]\p{L}\p{N}][[:graph:]\p{L}\p{N} ]*$'
+    $ref: ./siteName.v1.yaml
 required:
   - id
   - name

reference/clinic/models/siteCreation.v1.yaml

@@ -3,11 +3,6 @@ title: Site
 description: "A clinic's physical or logical location."
 properties:
   name:
-    type: string
-    x-go-type-skip-optional-pointer: true
-    description: The site description.
-    minLength: 1
-    maxLength: 200
-    pattern: '^[[:graph:]\p{L}\p{N}][[:graph:]\p{L}\p{N} ]*$'
+    $ref: ./siteName.v1.yaml
 required:
   - name

reference/clinic/models/siteId.v1.yaml

@@ -1,9 +1,6 @@
-title: Site ID
-description: >-
-  Site identifier.
-type: string
-minLength: 24
-maxLength: 24
-pattern: '^[a-f0-9]{24}$'
-readOnly: true
-example: 2fe2488217ee43e1b2e83c2f
+# Site id is a mongodb objectid, but not a pointer (like objectid.v1.yaml).
+allOf:
+  - $ref: ../../common/models/objectid.v1.yaml
+  - x-go-type-skip-optional-pointer: true
+    x-go-type: string # otherwise oapi-codegen will generate interface{}
+    readOnly: true # can't merge with objectid without this matching

reference/clinic/models/siteIds.v1.yaml

@@ -3,11 +3,4 @@ title: Site ID List
 uniqueItems: true
 nullable: true
 items:
-  title: Site ID
-  description: >-
-    Site identifier.
-  type: string
-  minLength: 24
-  maxLength: 24
-  pattern: '^[a-f0-9]{24}$'
-  readOnly: true
+  $ref: ./siteId.v1.yaml

reference/clinic/models/siteName.v1.yaml

@@ -0,0 +1,6 @@
+type: string
+x-go-type-skip-optional-pointer: true
+description: The site's name.
+minLength: 1
+maxLength: 200
+pattern: '^[[:graph:]\p{L}\p{N}][[:graph:]\p{L}\p{N} ]*$'