The variable 'cf_opts' is not used by 'DB::open_cf'

[iiibui]

rust-rocksdb/tests/cases/test_rocksdb_options.rs

Lines 345 to 374 in d8b7ff8

	#[test]
	fn test_set_lru_cache() {
	let path = tempdir_with_prefix("_rust_rocksdb_set_set_lru_cache");
	let mut opts = DBOptions::new();
	let mut cf_opts = ColumnFamilyOptions::new();
	opts.create_if_missing(true);
	let mut block_opts = BlockBasedOptions::new();
	let mut cache_opts = LRUCacheOptions::new();
	cache_opts.set_capacity(8388608);
	block_opts.set_block_cache(&Cache::new_lru_cache(cache_opts));
	cf_opts.set_block_based_table_factory(&block_opts);
	DB::open_cf(opts, path.path().to_str().unwrap(), vec!["default"]).unwrap();
	}
	#[cfg(feature = "jemalloc")]
	#[test]
	fn test_set_jemalloc_nodump_allocator_for_lru_cache() {
	use rocksdb::MemoryAllocator;
	let path = tempdir_with_prefix("_rust_rocksdb_set_jemalloc_nodump_allocator");
	let mut opts = DBOptions::new();
	let mut cf_opts = ColumnFamilyOptions::new();
	opts.create_if_missing(true);
	let mut block_opts = BlockBasedOptions::new();
	let mut cache_opts = LRUCacheOptions::new();
	cache_opts.set_memory_allocator(MemoryAllocator::new_jemalloc_memory_allocator().unwrap());
	cache_opts.set_capacity(8388608);
	block_opts.set_block_cache(&Cache::new_lru_cache(cache_opts));
	cf_opts.set_block_based_table_factory(&block_opts);
	DB::open_cf(opts, path.path().to_str().unwrap(), vec!["default"]).unwrap();
	}

DB::open_cf(opts, path.path().to_str().unwrap(), vec!["default"]).unwrap();
why not
DB::open_cf(opts, path.path().to_str().unwrap(), vec![("default", cf_opts)]).unwrap();

[tabokie]

Good catch, feel free to file a fixing PR.

This particular issue could be easily detected by clippy, but there're too many of them and we never get the time to fix them.