Ensure all modules have an id output (GoogleCloudPlatform#1410)

* net-vpc

* a-d

* complete modules

* fix error

Author: ludoo

blueprints/data-solutions/data-platform-foundations/06-common.tf

@@ -64,7 +64,7 @@ module "common-datacatalog" {
   tags       = var.data_catalog_tags
 }
 
-# To create KMS keys in the common projet: uncomment this section and assigne key links accondingly in local.service_encryption_keys variable
+# To create KMS keys in the common project: uncomment this section and assigne key links accondingly in local.service_encryption_keys variable
 
 # module "cmn-kms-0" {
 #   source     = "../../../modules/kms"

modules/artifact-registry/README.md

@@ -37,7 +37,7 @@ module "docker_artifact_registry" {
 
 | name | description | sensitive |
 |---|---|:---:|
-| [id](outputs.tf#L17) | Repository id. |  |
+| [id](outputs.tf#L17) | Fully qualified repository id. |  |
 | [name](outputs.tf#L22) | Repository name. |  |
 
 <!-- END TFDOC -->

modules/artifact-registry/outputs.tf

@@ -15,7 +15,7 @@
  */
 
 output "id" {
-  description = "Repository id."
+  description = "Fully qualified repository id."
   value       = google_artifact_registry_repository.registry.id
 }
 

modules/bigtable-instance/README.md

@@ -245,7 +245,7 @@ module "bigtable-instance" {
 
 | name | description | sensitive |
 |---|---|:---:|
-| [id](outputs.tf#L17) | An identifier for the resource with format projects/{{project}}/instances/{{name}}. |  |
+| [id](outputs.tf#L17) | Fully qualified instance id. |  |
 | [instance](outputs.tf#L26) | BigTable intance. |  |
 | [table_ids](outputs.tf#L35) | Map of fully qualified table ids keyed by table name. |  |
 | [tables](outputs.tf#L40) | Table resources. |  |

modules/bigtable-instance/outputs.tf

@@ -15,7 +15,7 @@
  */
 
 output "id" {
-  description = "An identifier for the resource with format projects/{{project}}/instances/{{name}}."
+  description = "Fully qualified instance id."
   value       = google_bigtable_instance.default.id
   depends_on = [
     google_bigtable_instance_iam_binding.default,

modules/billing-budget/README.md

@@ -84,6 +84,6 @@ module "pubsub" {
 | name | description | sensitive |
 |---|---|:---:|
 | [budget](outputs.tf#L17) | Budget resource. |  |
-| [id](outputs.tf#L22) | Budget ID. |  |
+| [id](outputs.tf#L22) | Fully qualified budget id. |  |
 
 <!-- END TFDOC -->

modules/billing-budget/outputs.tf

@@ -20,6 +20,6 @@ output "budget" {
 }
 
 output "id" {
-  description = "Budget ID."
+  description = "Fully qualified budget id."
   value       = google_billing_budget.budget.id
 }

modules/binauthz/README.md

@@ -73,7 +73,7 @@ module "binauthz" {
 | name | description | sensitive |
 |---|---|:---:|
 | [attestors](outputs.tf#L17) | Attestors. |  |
-| [id](outputs.tf#L25) | Binary Authorization policy ID. |  |
+| [id](outputs.tf#L25) | Fully qualified Binary Authorization policy ID. |  |
 | [notes](outputs.tf#L30) | Notes. |  |
 
 <!-- END TFDOC -->

modules/binauthz/outputs.tf

@@ -23,7 +23,7 @@ output "attestors" {
 }
 
 output "id" {
-  description = "Binary Authorization policy ID."
+  description = "Fully qualified Binary Authorization policy ID."
   value       = google_binary_authorization_policy.policy.id
 }
 

modules/cloud-dataplex/README.md

@@ -68,7 +68,8 @@ module "dataplex" {
 | name | description | sensitive |
 |---|---|:---:|
 | [assets](outputs.tf#L17) | Assets attached to the lake of Dataplex Lake. |  |
-| [lake](outputs.tf#L22) | The lake name of Dataplex Lake. |  |
-| [zones](outputs.tf#L27) | The zone name of Dataplex Lake. |  |
+| [id](outputs.tf#L22) | Fully qualified Dataplex Lake id. |  |
+| [lake](outputs.tf#L27) | The lake name of Dataplex Lake. |  |
+| [zones](outputs.tf#L32) | The zone name of Dataplex Lake. |  |
 
 <!-- END TFDOC -->