fix: remove Bun specific exceptions from Node compatible code

AriPerkkio · AriPerkkio · commit 08e8143e9098 · 2025-06-16T19:42:24.000+03:00
diff --git a/.github/workflows/bun.yml b/.github/workflows/bun.yml
@@ -10,20 +10,12 @@ on:
 jobs:
   test:
     name: Test (Bun)
-    strategy:
-      fail-fast: false
-      matrix:
-        os: [ubuntu-latest, macos-latest, windows-latest]
-        bun-version: [latest]
 
-    runs-on: ${{matrix.os}}
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
 
-      - name: Use Bun ${{ matrix.bun-version }}
-        uses: oven-sh/setup-bun@v2
-        with:
-          bun-version: ${{ matrix.bun-version }}
+      - uses: oven-sh/setup-bun@v2
 
       - uses: pnpm/action-setup@v2
 
@@ -33,5 +25,15 @@ jobs:
       - name: Build
         run: pnpm build
 
+      # Exclude tests that Bun is not compatible with
       - name: Test
-        run: bun run --bun test run
+        run: >-
+          bun run --bun test run --fileParallelism=false
+          --exclude **/async-context.test.ts
+          --exclude **/atomic.test.ts
+          --exclude **/pool-destroy.test.ts
+          --exclude **/resource-limits.test.ts
+          --exclude **/teardown.test.ts
+          --exclude **/termination.test.ts
+          --exclude **/uncaught-exception-from-handler.test.ts
+          --exclude **/worker-stdio.test.ts
diff --git a/src/index.ts b/src/index.ts
@@ -35,7 +35,6 @@ import {
 } from './common'
 import ThreadWorker from './runtime/thread-worker'
 import ProcessWorker from './runtime/process-worker'
-import { isBun } from './utils'
 
 declare global {
   namespace NodeJS {
@@ -1162,19 +1161,6 @@ class Tinypool extends EventEmitterAsyncResource {
       )
     }
 
-    if (isBun) {
-      if (options.useAtomics) {
-        throw new Error('options.useAtomics can not be set in Bun runtime')
-      }
-
-      // ::bunternal:: [NotImplementedError]: worker_threads.Worker option "resourceLimits" is not yet implemented in Bun.
-      if (options.resourceLimits) {
-        throw new Error('options.resourceLimits can not be set in Bun runtime.')
-      }
-
-      options.useAtomics = false
-    }
-
     super({ ...options, name: 'Tinypool' })
 
     if (
diff --git a/src/runtime/process-worker.ts b/src/runtime/process-worker.ts
@@ -150,7 +150,6 @@ export default class ProcessWorker implements TinypoolWorker {
 
     // The forked child_process adds event listener on `process.on('message)`.
     // This requires manual unreffing of its channel.
-    // Bun runtime does not have `unref` for the channel
     this.process.channel?.unref?.()
 
     if (hasUnref(this.process.stdout)) {
diff --git a/src/utils.ts b/src/utils.ts
@@ -7,5 +7,3 @@ export function stderr(): NodeJS.WriteStream | undefined {
   // @ts-expect-error Node.js maps process.stderr to console._stderr
   return console._stderr || process.stderr || undefined
 }
-
-export const isBun = 'bun' in process.versions
diff --git a/test/async-context.test.ts b/test/async-context.test.ts
@@ -2,17 +2,10 @@ import { createHook, executionAsyncId } from 'node:async_hooks'
 import { Tinypool } from 'tinypool'
 import { dirname, resolve } from 'node:path'
 import { fileURLToPath } from 'node:url'
-import { isBun } from './utils'
 
 const __dirname = dirname(fileURLToPath(import.meta.url))
 
-test('postTask() calls the correct async hooks', async ({ skip }) => {
-  // Async context tracking via createHook is highly experimental and even suggested by NodeJS migrate away from this.
-  // https://nodejs.org/docs/latest/api/async_hooks.html#async-hooks
-  // Experimental. Please migrate away from this API, if you can. We do not recommend using the createHook, AsyncHook,
-  // and executionAsyncResource APIs as they have usability issues, safety risks, and performance implications.
-  if (isBun) return skip('AsyncHooks are not yet supported in Bun')
-
+test('postTask() calls the correct async hooks', async () => {
   let taskId: number
   let initCalls = 0
   let beforeCalls = 0
diff --git a/test/atomic.test.ts b/test/atomic.test.ts
@@ -1,13 +1,10 @@
 import Tinypool from 'tinypool'
 import { dirname, resolve } from 'node:path'
 import { fileURLToPath } from 'node:url'
-import { isBun } from './utils'
 
 const __dirname = dirname(fileURLToPath(import.meta.url))
 
-test('coverage test for Atomics optimization', async ({ skip }) => {
-  if (isBun) return skip('Atomics are not supported in Bun')
-
+test('coverage test for Atomics optimization', async () => {
   const pool = new Tinypool({
     filename: resolve(__dirname, 'fixtures/notify-then-sleep-or.js'),
     minThreads: 2,
@@ -70,9 +67,7 @@ function popcount8(v: number): number {
   return v
 }
 
-test('avoids unbounded recursion', async ({ skip }) => {
-  if (isBun) return skip('Atomics are not yet supported in Bun')
-
+test('avoids unbounded recursion', async () => {
   const pool = new Tinypool({
     filename: resolve(__dirname, 'fixtures/simple-isworkerthread.js'),
     minThreads: 2,
diff --git a/test/pool-destroy.test.ts b/test/pool-destroy.test.ts
@@ -2,7 +2,6 @@ import { createHook } from 'node:async_hooks'
 import { dirname, resolve } from 'node:path'
 import { Tinypool } from 'tinypool'
 import { fileURLToPath } from 'node:url'
-import { isBun } from './utils'
 
 const __dirname = dirname(fileURLToPath(import.meta.url))
 
@@ -30,13 +29,7 @@ test('destroy after initializing should work (#43)', async () => {
   await promise
 })
 
-test('cleans up async resources', async ({ skip }) => {
-  // Async context tracking via createHook is highly experimental and even suggested by NodeJS migrate away from this.
-  // https://nodejs.org/docs/latest/api/async_hooks.html#async-hooks
-  // Experimental. Please migrate away from this API, if you can. We do not recommend using the createHook, AsyncHook,
-  // and executionAsyncResource APIs as they have usability issues, safety risks, and performance implications.
-  if (isBun) return skip('AsyncHooks are not yet supported in Bun')
-
+test('cleans up async resources', async () => {
   let onCleanup = () => {}
   const waitForCleanup = new Promise<void>((r) => (onCleanup = r))
   const timeout = setTimeout(() => {
diff --git a/test/resource-limits.test.ts b/test/resource-limits.test.ts
@@ -1,13 +1,10 @@
 import { dirname, resolve } from 'node:path'
 import { Tinypool } from 'tinypool'
 import { fileURLToPath } from 'node:url'
-import { isBun } from './utils'
 
 const __dirname = dirname(fileURLToPath(import.meta.url))
 
-test('resourceLimits causes task to reject', async ({ skip }) => {
-  if (isBun) return skip('process resourceLimits are not yet supported in Bun')
-
+test('resourceLimits causes task to reject', async () => {
   const worker = new Tinypool({
     filename: resolve(__dirname, 'fixtures/resource-limits.js'),
     resourceLimits: {
@@ -74,7 +71,7 @@ describe.each(['worker_threads', 'child_process'] as const)('%s', (runtime) => {
     }
 
     // Test setup should not reach max memory on first round
-    expect(rounds).toBeGreaterThan(0)
+    expect(rounds).toBeGreaterThan(1)
 
     // Thread should have been recycled
     expect(finalThreadId).not.toBe(originalWorkerId)
diff --git a/test/teardown.test.ts b/test/teardown.test.ts
@@ -16,7 +16,6 @@ test('isolated workers call teardown on worker recycle', async () => {
 
   for (const _ of [1, 2, 3, 4, 5]) {
     const { port1, port2 } = new MessageChannel()
-    port2.start()
     const promise = new Promise((resolve) => port2.on('message', resolve))
 
     const output = await pool.run({ port: port1 }, { transferList: [port1] })
@@ -42,10 +41,10 @@ test('non-isolated workers call teardown on worker recycle', async () => {
   }
 
   const { port1, port2 } = new MessageChannel()
-  port2.start()
-  port2.on('message', unexpectedTeardown)
 
   for (const index of [1, 2, 3, 4, 5]) {
+    port2.on('message', unexpectedTeardown)
+
     const transferList = index === 1 ? [port1] : []
 
     const output = await pool.run({ port: transferList[0] }, { transferList })
@@ -56,5 +55,5 @@ test('non-isolated workers call teardown on worker recycle', async () => {
   const promise = new Promise((resolve) => port2.on('message', resolve))
 
   await pool.destroy()
-  await expect(promise).resolves.toEqual(`Teardown of task #5`)
+  await expect(promise).resolves.toMatchInlineSnapshot(`"Teardown of task #5"`)
 })
diff --git a/test/termination.test.ts b/test/termination.test.ts
@@ -1,7 +1,6 @@
 import { dirname, resolve } from 'node:path'
 import { Tinypool } from 'tinypool'
 import { fileURLToPath } from 'node:url'
-import { isBun } from './utils'
 
 const __dirname = dirname(fileURLToPath(import.meta.url))
 const cleanups: (() => Promise<unknown>)[] = []
@@ -58,12 +57,7 @@ test('writing to terminating worker does not crash', async () => {
   await destroyed
 })
 
-test('recycling workers while closing pool does not crash', async ({
-  skip,
-}) => {
-  // TODO: Need to debug the weird issue for this test
-  if (isBun) return skip()
-
+test('recycling workers while closing pool does not crash', async () => {
   const pool = new Tinypool({
     runtime: 'child_process',
     filename: resolve(__dirname, 'fixtures/nested-pool.mjs'),
diff --git a/test/uncaught-exception-from-handler.test.ts b/test/uncaught-exception-from-handler.test.ts
@@ -49,7 +49,7 @@ test('uncaught exception in immediate after task yields error event', async () =
   pool.threads[0]!.ref?.()
 
   // This is the main aassertion here.
-  expect((await errorEvent)[0]!.message).toContain('not_caught')
+  expect((await errorEvent)[0]!.message).toEqual('not_caught')
 })
 
 test('using parentPort is treated as an error', async () => {
@@ -62,7 +62,7 @@ test('using parentPort is treated as an error', async () => {
       console.log();
       const parentPort = (await import('worker_threads')).parentPort;
       parentPort.postMessage("some message");
-      await new Promise(() => {}) /* act as if we were doing some work */
+      new Promise(() => {}) /* act as if we were doing some work */
     })()
       `)
   ).rejects.toThrow(/Unexpected message on Worker: 'some message'/)
diff --git a/test/utils.ts b/test/utils.ts
diff --git a/test/worker-stdio.test.ts b/test/worker-stdio.test.ts
@@ -2,15 +2,12 @@ import * as path from 'node:path'
 import { fileURLToPath } from 'node:url'
 import { stripVTControlCharacters } from 'node:util'
 import { Tinypool } from 'tinypool'
-import { isBun } from './utils'
 
 const runtimes = ['worker_threads', 'child_process'] as const
 const __dirname = path.dirname(fileURLToPath(import.meta.url))
 
 test.each(runtimes)(
   "worker's stdout and stderr are piped to main thread when { runtime: '%s' }",
-  // TODO: std options are not yet supported in Bun
-  { skip: isBun },
   async (runtime) => {
     const pool = createPool({
       runtime,
diff --git a/vitest.config.ts b/vitest.config.ts
@@ -4,8 +4,6 @@ import { fileURLToPath } from 'node:url'
 
 const __dirname = dirname(fileURLToPath(import.meta.url))
 
-const isBun = 'bun' in process.versions
-
 export default defineConfig({
   resolve: {
     alias: {
@@ -16,22 +14,6 @@ export default defineConfig({
     globals: true,
     isolate: false,
 
-    poolOptions: {
-      /**
-       * There is an issue with Vitest that is causing a weird Temporal Disposal Zone (TDZ) issue
-       * when used with multi-process with Bun.
-       * ReferenceError: Cannot access 'dispose' before initialization.
-       *  ❯ disposeInternalListeners node_modules/.pnpm/vitest@3.1.4_@types+node@20.12.8/node_modules/vitest/dist/chunks/utils.BfxieIyZ.js:19:19
-       *
-       * So we have to switch to single fork to run our tests in the Bun until resolved.
-       */
-      forks: isBun
-        ? {
-            singleFork: true,
-          }
-        : {},
-    },
-
     benchmark: {
       include: ['**/**.bench.ts'],
     },

Original file line number	Diff line number	Diff line change
`@@ -7,5 +7,3 @@ export function stderr(): NodeJS.WriteStream \| undefined {`
`7`	`7`	`// @ts-expect-error Node.js maps process.stderr to console._stderr`
`8`	`8`	`return console._stderr \|\| process.stderr \|\| undefined`
`9`	`9`	`}`
`10`		`-`
`11`		`-export const isBun = 'bun' in process.versions`