Skip to content

coding style and variable naming #3

Description

@andy-Chien

The action name Hiwinmodbus is vague and confusing. For the user, that action is not associated with modbus.
IP address should be passed in by parameter system, not via action goal.
Automatically connect to the robot when launch this node should be better.
Name of class member variables should start or end with underscore, and they are usually private.
The declaration of member variables in a class is usually placed after functions.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions