The action name Hiwinmodbus is vague and confusing. For the user, that action is not associated with modbus.
IP address should be passed in by parameter system, not via action goal.
Automatically connect to the robot when launch this node should be better.
Name of class member variables should start or end with underscore, and they are usually private.
The declaration of member variables in a class is usually placed after functions.
The action name Hiwinmodbus is vague and confusing. For the user, that action is not associated with modbus.
IP address should be passed in by parameter system, not via action goal.
Automatically connect to the robot when launch this node should be better.
Name of class member variables should start or end with underscore, and they are usually private.
The declaration of member variables in a class is usually placed after functions.