Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow the XDG Base Directory Specification #346

Open
Wsine opened this issue Apr 29, 2021 · 5 comments
Open

Follow the XDG Base Directory Specification #346

Wsine opened this issue Apr 29, 2021 · 5 comments

Comments

@Wsine
Copy link

Wsine commented Apr 29, 2021

Expected behaviour

Move the default config file location to ${XDG_CONFIG_HOME:-$HOME/.config}/tldr/tldrrc
Also move the default cache file location to ${XDG_CACHE_HOME:-$HOME/.cache}/tldr

Actual behaviour

Current config file location $HOME/.tldrrc
Current cache file location $HOME/.tldr/cache

Environment

  • Operating system - OSX/Linux
@bl-ue
Copy link
Contributor

bl-ue commented Apr 29, 2021

This will probably have to go into 4.0.0 as it's a breaking change. Or maybe we can search for both paths for the config file and cache directory.

@bl-ue bl-ue added the bug label Apr 29, 2021
@vladimyr
Copy link
Collaborator

This will probably have to go into 4.0.0 as it's a breaking change. Or maybe we can search for both paths for the config file and cache directory.

I'm definitely in support both camp because not everyone agrees on XDG and breaking changes should be avoided unless they are absolutely neccessary.

@vladimyr vladimyr added enhancement and removed bug labels Apr 29, 2021
@vladimyr
Copy link
Collaborator

@bl-ue I don't really care about label names but picking bug is problematic because Refined Github lists them in another tab 🙃

@bl-ue
Copy link
Contributor

bl-ue commented Apr 29, 2021

No problem. Yeah, refined GitHub is pretty cool, but there were some UI quirks that I didn't like, but I guess that with the amount of features it provides I'll keep it.

By the way, how did you figure out to get that #:~:text=... stuff in the URL? I've seen it before but not from human-typed links like that.

@vladimyr
Copy link
Collaborator

but there were some UI quirks that I didn't like, but I guess that with the amount of features it provides I'll keep it.

Same here. FWIW they have a ton of customization options plus they are pretty responsive and welcoming to constructive feedback.

By the way, how did you figure out to get that #:~:text=... stuff in the URL? I've seen it before but not from human-typed links like that.

Sooner or later I'll reveal all of my tricks 😅 https://github.com/GoogleChromeLabs/link-to-text-fragment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants