Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Parse id, username, filename from the Gist #3

Open
oyeanuj opened this issue Mar 6, 2017 · 4 comments · May be fixed by #6
Open

Feature Request: Parse id, username, filename from the Gist #3

oyeanuj opened this issue Mar 6, 2017 · 4 comments · May be fixed by #6

Comments

@oyeanuj
Copy link

oyeanuj commented Mar 6, 2017

Hi @tleunen, thank you for putting out this component!

I was wondering about your thoughts on the component accepting a gist url and then parsing information to show relevant gist/file?

I imagine that this would be a common enough use-case that a lot of people would be reinventing when they use this component.

@tleunen
Copy link
Owner

tleunen commented Mar 6, 2017

Hey @oyeanuj.

Yes, I believe this could be added as well. Indeed, people probably have the url instead of the specific id. So we could have a url prop which will parse it to know what we have to display...

@oyeanuj
Copy link
Author

oyeanuj commented Mar 6, 2017

Awesome! Another advantage I realized would be that incase url format changes in the future, the change needs to only be made in one place by the library rather then everyone else!

Also, appreciate the instant response :)

@tleunen
Copy link
Owner

tleunen commented Mar 6, 2017

Feel free to submit a PR if you're interested in taking that :)

@oyeanuj
Copy link
Author

oyeanuj commented Mar 6, 2017

I am not that good with regexes but will share a solution if I end up with one, as I soon plan to integrate with the library.

Btw, If you are more familiar with regex, then I'm sure I could create a PR with your help!

@hipstersmoothie hipstersmoothie linked a pull request Jun 11, 2018 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants