Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't wrap chordsFromNumerals output by default #37

Open
tmhglnd opened this issue Aug 15, 2023 · 1 comment
Open

Don't wrap chordsFromNumerals output by default #37

tmhglnd opened this issue Aug 15, 2023 · 1 comment

Comments

@tmhglnd
Copy link
Owner

tmhglnd commented Aug 15, 2023

All generated chords are currently wrapped within one octave to keep chords close together. But this is not always ideal, so this could be added as an option or done manually with the Util.wrap() method.

@tmhglnd
Copy link
Owner Author

tmhglnd commented Sep 29, 2023

Chord wrapping already happens because of the return from Tonal. eg:

> chordsFromNames(['Cm11'])
chord {
  empty: false,
  name: 'C minor eleventh',
  setNum: 2898,
  chroma: '101101010010',
  normalized: '100101011010',
  intervals: [ '1P', '3m', '5P', '7m', '9M', '11P' ],
  quality: 'Minor',
  aliases: [ 'm11', '-11' ],
  symbol: 'Cm11',
  type: 'minor eleventh',
  root: '',
  rootDegree: 0,
  tonic: 'C',
  notes: [ 'C', 'Eb', 'G', 'Bb', 'D', 'F' ]
}

In this case .notes is used, translated to semitone numbers, resulting in values between 0-12. Have to investigate how to get around this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant