fix attrTokenRe splitting attributes with template actions containing quotes

The attrTokenRe regex used [^"]* for double-quoted attribute values, which stopped at the first quote inside a template action. For attributes like aria-sort="{{if eq .SortBy "check_in"}}...", the regex matched only up to the inner quote, splitting the attribute and corrupting formatted output.

Updated the regex to match {{...}} template actions atomically before individual characters, so inner quotes within actions are consumed as part of the action.

Also replaced the allOverflow wrapping bailout with a simpler len(attrs)<=1 check. The previous logic incorrectly abandoned wrapping when a long template-containing attribute was the last attr on a continuation line, even though wrapping still reduced the first line's width.

Author: Jason-Abbott

.beans/.sync.json

@@ -25,6 +25,12 @@
         "synced_at": "2026-02-02T23:55:16.331753Z"
       }
     },
+    "golsp-hyo6": {
+      "clickup": {
+        "task_id": "868hb9ny4",
+        "synced_at": "2026-02-03T00:09:58.074886Z"
+      }
+    },
     "golsp-ijrh": {
       "clickup": {
         "task_id": "868hb0hr0",
@@ -72,6 +78,12 @@
         "task_id": "868hb9fwx",
         "synced_at": "2026-02-02T23:55:16.39934Z"
       }
+    },
+    "golsp-whzj": {
+      "clickup": {
+        "task_id": "868hb9ny2",
+        "synced_at": "2026-02-03T00:09:57.984258Z"
+      }
     }
   }
 }

.beans/golsp-9w5l--fix-attrtokenre-splitting-attributes-with-template.md

@@ -0,0 +1,11 @@
+---
+# golsp-9w5l
+title: Fix attrTokenRe splitting attributes with template actions containing quotes
+status: completed
+type: bug
+priority: normal
+created_at: 2026-02-03T00:56:48Z
+updated_at: 2026-02-03T01:01:19Z
+---
+
+The attrTokenRe regex uses [^"]* for double-quoted attribute values, which breaks on attributes like aria-sort="{{if eq .SortBy "check_in"}}ascending{{else}}none{{end}}". The regex matches up to the first inner quote, splitting the attribute into garbage tokens and corrupting the formatted output.

internal/template/format.go

@@ -36,7 +36,7 @@ var (
 	// attrTokenRe matches individual attribute chunks: name="value", name='value',
 	// name, or template actions {{...}}.
 	attrTokenRe = regexp.MustCompile(
-		`(\{\{.*?\}\}(?:[^\s<>]*\{\{.*?\}\})*[^\s<>]*|\S+?="[^"]*"|\S+?='[^']*'|[^\s>]+)`,
+		`(\{\{.*?\}\}(?:[^\s<>]*\{\{.*?\}\})*[^\s<>]*|\S+?="(?:\{\{.*?\}\}|[^"])*"|\S+?='(?:\{\{.*?\}\}|[^'])*'|[^\s>]+)`,
 	)
 
 	// tmplBlockRe matches template block-opening keywords.
@@ -325,15 +325,9 @@ func wrapAttributes(
 		lines = append(lines, currentLine+closer+afterClose)
 	}
 
-	// If every continuation line still exceeds printWidth, wrapping didn't help
-	allOverflow := true
-	for _, line := range lines[1:] {
-		if lineWidth(line, opts.TabSize) <= opts.PrintWidth {
-			allOverflow = false
-			break
-		}
-	}
-	if allOverflow {
+	// With only one attribute, wrapping just moves it to the next line without
+	// reducing the overall width — skip wrapping in that case.
+	if len(attrs) <= 1 {
 		return nil, false
 	}
 

internal/template/format_test.go

@@ -739,6 +739,24 @@ title="Expand">`,
   </section>
 </dialog>
 {{end}}`,
+		},
+		{
+			name: "attribute with template action containing inner quotes",
+			input: `<th scope="col" class="booked-on" data-sort-field="booked_on" aria-sort="{{if eq .SortBy "booked_on"}}ascending{{else if eq .SortBy "-booked_on"}}descending{{else}}none{{end}}">
+Booked<br/>On
+<span class="sort-icon"></span>
+</th>`,
+			opts: FormatOptions{
+				TabSize:      3,
+				InsertSpaces: true,
+				PrintWidth:   100,
+				AttrWrapMode: "overflow",
+			},
+			expected: `<th scope="col" class="booked-on" data-sort-field="booked_on"
+   aria-sort="{{if eq .SortBy "booked_on"}}ascending{{else if eq .SortBy "-booked_on"}}descending{{else}}none{{end}}">
+   Booked<br/>On
+   <span class="sort-icon"></span>
+</th>`,
 		},
 		{
 			name:  "default opts no wrapping",