feat(optimizer)!: Annotate type for snowflake COT, SIN and TAN functions (#6022)

Author: fivetran-amrutabhimsenayachit

sqlglot/dialects/snowflake.py

@@ -563,6 +563,12 @@ class Snowflake(Dialect):
 
     TYPE_TO_EXPRESSIONS = {
         **Dialect.TYPE_TO_EXPRESSIONS,
+        exp.DataType.Type.DOUBLE: {
+            *Dialect.TYPE_TO_EXPRESSIONS[exp.DataType.Type.DOUBLE],
+            exp.Cot,
+            exp.Sin,
+            exp.Tan,
+        },
         exp.DataType.Type.INT: {
             *Dialect.TYPE_TO_EXPRESSIONS[exp.DataType.Type.INT],
             exp.Ascii,

sqlglot/expressions.py

@@ -5549,6 +5549,10 @@ class Sinh(Func):
     pass
 
 
+class Tan(Func):
+    pass
+
+
 class CosineDistance(Func):
     arg_types = {"this": True, "expression": True}
 

tests/dialects/test_snowflake.py

@@ -19,6 +19,7 @@ def test_snowflake(self):
         self.assertEqual(ast.sql("snowflake"), "DATEADD(MONTH, n, d)")
 
         self.validate_identity("SELECT GET(a, b)")
+        self.validate_identity("SELECT TAN(x)")
         self.assertEqual(
             # Ensures we don't fail when generating ParseJSON with the `safe` arg set to `True`
             self.validate_identity("""SELECT TRY_PARSE_JSON('{"x: 1}')""").sql(),

tests/fixtures/optimizer/annotate_functions.sql

@@ -1683,6 +1683,10 @@ BINARY;
 COLLATION('hello');
 VARCHAR;
 
+# dialect: snowflake
+COT(tbl.double_col);
+DOUBLE;
+
 # dialect: snowflake
 CONCAT('Hello', 'World!');
 VARCHAR;
@@ -2151,6 +2155,10 @@ VARCHAR;
 SHA2_HEX('foo', null);
 VARCHAR;
 
+# dialect: snowflake
+SIN(tbl.double_col);
+DOUBLE;
+
 # dialect: snowflake
 SOUNDEX(tbl.str_col);
 VARCHAR;
@@ -2259,6 +2267,10 @@ BINARY;
 SUBSTR(tbl.str_col, NULL);
 STRING;
 
+# dialect: snowflake
+TAN(tbl.double_col);
+DOUBLE;
+
 # dialect: snowflake
 TRANSLATE('hello world', 'elo', 'XYZ');
 VARCHAR;