Add termials #101
Add termials #101
Conversation
remove CalculationRequest
fix terminal digits remove broken terminal approx
add tests for terminals (chains) fix terminal in chain regex fix dedup of complex chains (now by capture)
|
Currently I fear that it would spam the existing subreddits* with replies. Especially the major subreddits like mathmemes and theydidthemath would get spammed by little factorion.
I'm not sure what the solution should be and I'd like to hear what you think :) *mathmemes, mathmemescirclejerk, unexpectedfactorial, factorialchain, doublefactorialchain, theydidthemath, theydidthemonstermath |
|
Why not all? Check for terminals if it's a direct mention or in a whitelisted subreddit or explicitly enabled via command. All those sound pretty easy (might also improve mention parent check behaviour while I'm at it). While command is the least invasive, that would make it go pretty much fully unused, so the whitelist makes sense (especially for unexpectedfactorial) and then I might as well add the mention exception too. |
|
Thought: Should this perhaps also apply to subfactorials? |
|
We also could use all of the suggestions, sure. The only argument against is the effort. We could use use that for subfactorials, you're right, but subfactorials are very rarely used, since it's hard to make an subfactorial on accident (compared to factorials and terminals) |
add terminal whitelist add terminal on mention add terminal on command
add terminal of approximate math function refactor CalculationJob::execute to reduce code duplication fix mixed chain calculation fix order of tower levels
|
Added those rules, so subreddit whitelist (TERMINAL_SUBREDDITS env var), mentions and command ("terminal" and "triangle"). Also improved the accuracy of tower fallback (for terminals) and improved that code. (Also noticed that I was wrong about including repeated logs in nested towers, so removed that) |
…that are not in TERMINAL_SUBREDDITS
|
Give me a heads up when the PR is ready for review :) |
|
Should be all good now, can't think of anything I need to do :) |
|
I just figured out we both were using "terminal", instead of "termial", lol. |
|
Oops ^_^' gonna fix that later |
|
Looks good, i’m excited to see it in the wild. |
I implemented termials including fractional termials and chains.
The results can be exact, approximate, digits and tower.
In the end, I removed both Calculation enums, as it made more sense to keep it as a factorial level 0.
As I ran into a dedup issue with those chains, I reworked that, so that it dedups based on capture.
Further:
Resolves #53