Make p2pSocket (socket, next, room) take room as string

[phonon]

I initially had trouble getting peers to only connect within some socket room using the function p2pSocket (socket, next, room). The source of the confusion was on the server side in the socket.io-p2p-server/index.js code:

function p2pSocket (socket, next, room) {
  clients[socket.id] = socket
  if (typeof room === 'object') {
    var connectedClients = socket.adapter.rooms[room.name]
  } else {
    var connectedClients = clients
  }
//...

where this requires that the input room be an object. I was passing in room as a string, so this socket.io-p2p-server was connecting me to all clients rather than clients within the room.

Is there any reason that p2pSocket (socket, next, room) requires room to be an object? Based on the code, room is only used to access the room.name string to find the clients in that socket room in that first block cited above. Why not allow clients to pass in room as a string. I think this would reduce some confusion about using p2pSocket. Or maybe even something like:

  if (typeof room === 'object') {
    // ...
  } else if (typeof room === 'string') {
    // ...
  } else {
    // ...
  }

In the mean time, as a hack I have been invoking this function p2pSocket like:

// ...
var p2p = require('socket.io-p2p-server').Server;
// ...
p2p(socket, null, {name: room});

so that the room input is recognized as an object.

Thanks!

[rameshvarun]

+1 - It seems unnecessary to require that an object be passed in. Changing the room parameter to a string will make it match the join calls from the main socket.io library.

[Aeyos]

The room Object has changed, proposing to also change

var connectedClients = socket.adapter.rooms[room.name]

to

var connectedClients = socket.adapter.rooms[room].sockets

[bennytheshap]

@Aeyos Am I correct that the change to the Room object means that this library is currently broken when trying to only establish a WebRTC connection with clients in the same room?

I get an exception when trying to use the following code:

io.on('connection', function (socket) {
  socket.on('join-room', function(roomName){
    socket.join(roomName)
    p2pserver(socket, null, {name:roomName})
  })
  ...

The exception is:

/Users/ben/devel/socket.io-p2p/node_modules/socket.io-p2p-server/index.js:33
        client.emit('offer', emittedOffer)
TypeError: Cannot read property 'emit' of undefined
    at /Users/ben/devel/socket.io-p2p/node_modules/socket.io-p2p-server/index.js:33:15

[swiftmas]

Having the same issue. was this project dropped or do people not use rooms? I have to use my own branch with the change aeyos mentioned