Skip to content

Commit df2e75b

Browse files
authored
Merge pull request #47 from cjalmeida/windows_port_merge
Fixes to installer
2 parents cbedd1e + 572eb5a commit df2e75b

File tree

2 files changed

+11
-23
lines changed

2 files changed

+11
-23
lines changed

build-windows.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828

2929

3030
## package setup.exe
31-
- Download 32 bit version of these libs [VSC++2015 SP3](https://www.microsoft.com/en-us/download/details.aspx?id=53840), [VSC++2010Sp1](https://www.microsoft.com/en-us/download/details.aspx?id=26999) and put in folder `pxCore\pxCore.vsbuild\pxScene2d`.
31+
- Download 32 bit version of [VSC++2017](https://go.microsoft.com/fwlink/?LinkId=746571), and put in folder `pxCore\pxCore.vsbuild\pxScene2d`.
3232
- use inno setup Compiler open `pxCore\pxCore.vsbuild\pxScene2d\make_package.iss`
3333
- modify `Files` section, `Source` to your exe path.
3434
- use `build->Compile` , after that , you can find `setup.exe` at `pxCore\pxCore.vsbuild\pxScene2d\Output` ,you can double click to install pxscene

pxCore.vsbuild/pxScene2d/make_package.iss

+10-22
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ AppSupportURL=http://www.example.com/
1414
AppUpdatesURL=http://www.example.com/
1515
DefaultDirName={pf}\pxScene
1616
DisableProgramGroupPage=yes
17-
OutputBaseFilename=setup
17+
OutputBaseFilename=pxSetup
1818
Compression=lzma
1919
SolidCompression=yes
2020

@@ -25,20 +25,16 @@ Name: "english"; MessagesFile: "compiler:Default.isl"
2525
Name: "desktopicon"; Description: "{cm:CreateDesktopIcon}"; GroupDescription: "{cm:AdditionalIcons}"; Flags: unchecked
2626

2727
[Files]
28-
; Visual C++ 2010 SP1 Redist(x86) installer
29-
Source: "C:\wk\pxCore\pxCore.vsbuild\pxScene2d\vcredist_x86.exe"; DestDir: {tmp}; Flags: deleteafterinstall
3028
; Visual C++ 2015 SP3 Redist(x86)installer
31-
Source: "C:\wk\pxCore\pxCore.vsbuild\pxScene2d\vc_redist.x86.exe"; DestDir: {tmp}; Flags: deleteafterinstall
32-
Source: "C:\wk\pxCore\pxCore.vsbuild\pxScene2d\exe\pxScene.exe"; DestDir: "{app}"; Flags: ignoreversion;
33-
Source: "C:\wk\pxCore\pxCore.vsbuild\pxScene2d\exe\*"; DestDir: "{app}"; Flags: ignoreversion recursesubdirs createallsubdirs
29+
Source: "vc_redist.x86.exe"; DestDir: "{tmp}"; Flags: deleteafterinstall
30+
Source: "exe\pxScene.exe"; DestDir: "{app}"; Flags: ignoreversion;
31+
Source: "exe\*"; DestDir: "{app}"; Flags: ignoreversion recursesubdirs createallsubdirs
3432
; NOTE: Don't use "Flags: ignoreversion" on any shared system files
3533

3634
[Run]
3735
; the conditional installation Check
38-
; install Visual C++ 2010 SP1 Redist(x86) if not exist
39-
Filename: "{tmp}\vcredist_x86.exe"; Parameters: "/q /norestart"; StatusMsg: "Installing Microsoft Visual C++ 2010 SP1 Runtime ..."; Check: VC2010SP1RedistNeedsInstall
40-
; install Visual C++ 2015 SP3 Redist(x86) if not exist
41-
Filename: "{tmp}\vc_redist.x86.exe"; Parameters: "/q /norestart"; StatusMsg: "Installing Microsoft Visual C++ 2015 SP3 Runtime ..."; Check: VC2015SP3RedistNeedsInstall
36+
; install Visual C++ 2017 Redist(x86) if not exist
37+
Filename: "{tmp}\vc_redist.x86.exe"; Parameters: "/q /norestart"; StatusMsg: "Installing Microsoft Visual C++ 2017 Runtime ..."; Check: VC2017RedistNeedsInstall
4238

4339
[Code]
4440
#IFDEF UNICODE
@@ -55,11 +51,8 @@ const
5551
INSTALLSTATE_ABSENT = 2; { The product is installed for a different user. }
5652
INSTALLSTATE_DEFAULT = 5; { The product is installed for the current user. }
5753
58-
{Visual C++ 2010 SP1 Redist(x86) 10.0.40219}
59-
VC_2010_SP1_REDIST_X86 = '{F0C3E5D1-1ADE-321E-8167-68EF0DE699A5}';
60-
61-
{Visual C++ 2015 SP3 Redist(x86) 14.0.24215}
62-
VC_2015_SP3_REDIST_X86 = '{BBF2AC74-720C-3CB3-8291-5E34039232FA}';
54+
{Visual C++ 2017 Redist(x86) 14.10.25017}
55+
VC_2017_REDIST_X86 = '{582EA838-9199-3518-A05C-DB09462F68EC}';
6356
6457
function MsiQueryProductState(szProduct: string): INSTALLSTATE;
6558
external 'MsiQueryProductState{#AW}@msi.dll stdcall';
@@ -69,14 +62,9 @@ begin
6962
Result := not (MsiQueryProductState(ProductID) = INSTALLSTATE_DEFAULT);
7063
end;
7164
72-
function VC2010SP1RedistNeedsInstall: Boolean;
65+
function VC2017RedistNeedsInstall: Boolean;
7366
begin
74-
Result := VCVersionInstalled(VC_2010_SP1_REDIST_X86);
75-
end;
76-
77-
function VC2015SP3RedistNeedsInstall: Boolean;
78-
begin
79-
Result := VCVersionInstalled(VC_2015_SP3_REDIST_X86);
67+
Result := VCVersionInstalled(VC_2017_REDIST_X86);
8068
end;
8169
8270
function NextButtonClick(CurPageID: Integer): Boolean;

0 commit comments

Comments
 (0)