Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder exception as some are not reachable #159

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fabienheureux
Copy link
Contributor

@fabienheureux fabienheureux commented Aug 31, 2022

I am working on an importer for another CMS (Spip), and base some of it on wagtail-wordpress-import.
I noticed (thanks to my linter) that some exceptions were not reachable in this try / except block.

This PR fixes that :)

  • Testing
    • CI passes
    • If necessary, tests are added for new or fixed behaviour
    • These changes do not reduce test coverage
  • Documentation.
    • This PR adds or updates documentation
    • Documentation changes are not necessary because these does neither touch to existing features nor business logic

@fabienheureux fabienheureux marked this pull request as ready for review August 31, 2022 15:22
@nickmoreton
Copy link
Collaborator

Hi @fabienheureux Thanks for the PR

I'm not sure when I will get time to review this soon but will do asap.

@nickmoreton nickmoreton self-requested a review September 8, 2022 15:29
@fabienheureux
Copy link
Contributor Author

@nickmoreton I am cleaning up old PRs.

Can I close this one ?
I won't have time in a near future to continue working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants