Skip to content

Commit a7746d1

Browse files
committed
Add deprecation warnings
1 parent c166432 commit a7746d1

File tree

3 files changed

+25
-3
lines changed

3 files changed

+25
-3
lines changed

src/wagtailmedia/deprecation.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
class RemovedInWagtailMedia015Warning(PendingDeprecationWarning):
1+
class RemovedInWagtailMedia017Warning(PendingDeprecationWarning):
22
pass
33

44

5-
class RemovedInWagtailMedia016Warning(DeprecationWarning):
5+
class RemovedInWagtailMedia018Warning(DeprecationWarning):
66
pass

src/wagtailmedia/edit_handlers.py

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
11
from __future__ import annotations
22

3+
import warnings
4+
35
from typing import TYPE_CHECKING
46

57
from django.template.loader import render_to_string
68
from wagtail.admin.compare import ForeignObjectComparison
79
from wagtail.admin.panels import FieldPanel
810

11+
from .deprecation import RemovedInWagtailMedia018Warning
912
from .models import MediaType
1013
from .utils import format_audio_html, format_video_html
1114
from .widgets import AdminAudioChooser, AdminMediaChooser, AdminVideoChooser
@@ -23,6 +26,26 @@ def __init__(self, field_name, *args, media_type=None, **kwargs):
2326

2427
self.media_type = media_type
2528

29+
if self.media_type is None:
30+
warnings.warn(
31+
(
32+
"The `MediaChooserPanel` field panel is deprecated. "
33+
"Please use the `FieldPanel()` instead."
34+
),
35+
RemovedInWagtailMedia018Warning,
36+
stacklevel=2,
37+
)
38+
else:
39+
warnings.warn(
40+
(
41+
"The `MediaChooserPanel` field panel is deprecated. Please use the "
42+
"specialised `AudioChooserPanel()` for audio only "
43+
"and `VideoChooserPanel()` for video only."
44+
),
45+
RemovedInWagtailMedia018Warning,
46+
stacklevel=2,
47+
)
48+
2649
def clone_kwargs(self):
2750
kwargs = super().clone_kwargs()
2851
kwargs.update(media_type=self.media_type)

src/wagtailmedia/views/viewsets.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
from django.utils.functional import cached_property
22
from django.utils.translation import gettext_lazy as _
3-
43
from wagtail.admin.ui.tables import Column
54
from wagtail.admin.views.generic.chooser import (
65
ChooseResultsView,

0 commit comments

Comments
 (0)