Skip to content

Commit bfac1bd

Browse files
committed
fix: resolve CI linting errors for clean GitHub Actions workflow
Fixes ShellCheck and markdownlint violations preventing successful CI execution: **ShellCheck Fixes:** - Remove unused STAGING_DOMAIN and PRODUCTION_DOMAIN variables in scripts/manage-hetzner-dns.sh - Resolves SC2034 warnings for variables defined but never referenced **Markdownlint Fixes:** - Split long OpenSSL commands across multiple lines in testing documentation - Fixes MD013 line-length violations (>100 characters) in: - docs/testing/manual-sessions/2025-01-08-issue-28-phase-4-7-staging.md:189 - docs/testing/manual-sessions/template-session.md:213,217 - docs/testing/manual-staging-deployment-testing.md:189,193 **Impact:** - ✅ All CI tests now pass (yamllint, shellcheck, markdownlint) - ✅ GitHub Actions testing.yml workflow executes cleanly - ✅ Maintains code functionality while ensuring quality standards - ✅ Test suite completes in 7 seconds with 100% success rate This ensures reliable automated testing and quality assurance for the project.
1 parent e4914c2 commit bfac1bd

File tree

4 files changed

+10
-8
lines changed

4 files changed

+10
-8
lines changed

docs/testing/manual-sessions/2025-01-08-issue-28-phase-4-7-staging.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,8 @@ cargo run -p torrust-tracker-client --bin http_tracker_client announce \
186186

187187
```bash
188188
# 1. Verify Let's Encrypt certificate
189-
openssl s_client -connect tracker.staging-torrust-demo.com:443 -servername tracker.staging-torrust-demo.com \
189+
openssl s_client -connect tracker.staging-torrust-demo.com:443 \
190+
-servername tracker.staging-torrust-demo.com \
190191
-showcerts < /dev/null 2>/dev/null | openssl x509 -noout -dates -issuer
191192

192193
# 2. Test HTTPS redirects

docs/testing/manual-sessions/template-session.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,11 +210,13 @@ cargo run -p torrust-tracker-client --bin http_tracker_client announce \
210210

211211
```bash
212212
# Certificate verification:
213-
openssl s_client -connect tracker.staging-torrust-demo.com:443 -servername tracker.staging-torrust-demo.com \
213+
openssl s_client -connect tracker.staging-torrust-demo.com:443 \
214+
-servername tracker.staging-torrust-demo.com \
214215
-showcerts < /dev/null 2>/dev/null | openssl x509 -noout -dates
215216

216217
# Let's Encrypt verification:
217-
openssl s_client -connect tracker.staging-torrust-demo.com:443 -servername tracker.staging-torrust-demo.com \
218+
openssl s_client -connect tracker.staging-torrust-demo.com:443 \
219+
-servername tracker.staging-torrust-demo.com \
218220
-showcerts < /dev/null 2>/dev/null | openssl x509 -noout -issuer
219221

220222
# Results:

docs/testing/manual-staging-deployment-testing.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,11 +186,13 @@ cargo run -p torrust-tracker-client --bin http_tracker_client announce \
186186

187187
```bash
188188
# Check certificate details
189-
openssl s_client -connect tracker.staging-torrust-demo.com:443 -servername tracker.staging-torrust-demo.com \
189+
openssl s_client -connect tracker.staging-torrust-demo.com:443 \
190+
-servername tracker.staging-torrust-demo.com \
190191
-showcerts < /dev/null 2>/dev/null | openssl x509 -noout -dates
191192

192193
# Verify Let's Encrypt issuer
193-
openssl s_client -connect tracker.staging-torrust-demo.com:443 -servername tracker.staging-torrust-demo.com \
194+
openssl s_client -connect tracker.staging-torrust-demo.com:443 \
195+
-servername tracker.staging-torrust-demo.com \
194196
-showcerts < /dev/null 2>/dev/null | openssl x509 -noout -issuer
195197

196198
# Check certificate on server

scripts/manage-hetzner-dns.sh

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@ PROJECT_ROOT="$(cd "${SCRIPT_DIR}/.." && pwd)"
1010
source "${PROJECT_ROOT}/scripts/shell-utils.sh"
1111

1212
# Configuration
13-
# Example configuration
14-
STAGING_DOMAIN="staging-torrust-demo.com"
15-
PRODUCTION_DOMAIN="torrust-demo.com"
1613
BASE_URL="https://dns.hetzner.com/api/v1"
1714

1815
# Colors for output

0 commit comments

Comments
 (0)