refactor: modernize Perl code following perlstyle conventions

- Update .github/copilot-instructions.md with comprehensive Perl style guide
- Rename provision.pm -> Provision.pm to follow CamelCase convention
- Update package name TorrustDeploy::App::Command::provision -> Provision
- Modernize Perl version declarations: use v5.40 instead of separate pragmas
- Update all module references in tests and documentation
- Verify functionality with successful VM provisioning test

Follows perlstyle conventions for consistent, readable code organization.

Author: josecelano

.github/copilot-instructions.md

@@ -4,6 +4,66 @@ A modern Perl console application for deploying Torrust Tracker to Hetzner Cloud
 
 ## Code Quality Standards
 
+### Perl Code Organization
+
+Follow [perlstyle](https://perldoc.perl.org/5.42.0/perlstyle) conventions for consistent, readable code.
+
+#### Core Requirements
+
+- **Always use strict and warnings**: `use strict; use warnings;` or `use v5.36;` (enables both)
+- **Modern Perl**: Use `use v5.40;` or higher for modern features (enables strict, warnings, and more)
+
+#### Naming Conventions
+
+- **Package names**: Mixed case starting with capital letter, no underscores
+
+  - Example: `TorrustDeploy::App::Command::Provision`
+  - Lowercase reserved for pragmas (`strict`, `warnings`, `integer`)
+
+- **Variable naming by scope**:
+
+  - `$ALL_CAPS_HERE` - constants only
+  - `$Some_Caps_Here` - package-wide global/static variables
+  - `$no_caps_here` - function scope `my()` or `local()` variables
+
+- **Function and method names**: All lowercase with underscores
+
+  - Example: `$obj->as_string()`, `provision_infrastructure()`
+
+- **Leading underscore**: Indicates private/internal use only
+  - Example: `_internal_helper()`, `$_private_var`
+
+#### Directory Structure
+
+- **Module directories (`lib/`)**: CamelCase following package names
+
+  - Example: `lib/TorrustDeploy/App/Command/Provision.pm`
+  - Each `::` separator becomes a directory `/` in the filesystem
+
+- **Test directories (`t/`)**: Lowercase with hyphens or underscores
+
+  - Example: `t/001-basic.t`, `t/provision-command.t`, `t/integration/tofu-provider.t`
+  - Follow established Perl testing conventions
+
+- **Standard project directories**: Use lowercase
+
+  - `lib/`, `bin/`, `t/`, `xt/`, `share/`, `templates/`, `script/`, `build/`
+
+- **General project directories**: Use lowercase with underscores for separation
+  - Example: `cloud_init/`, `user_data/`, `config_templates/`
+
+#### Code Style
+
+- **Indentation**: 4-column indent
+- **Braces**: Opening curly on same line as keyword, if possible
+- **Spacing**:
+  - Space before opening curly of multi-line BLOCK
+  - Space around most operators
+  - Space after each comma
+  - No space between function name and opening parenthesis
+- **Line breaks**: Break long lines after an operator (except `and`/`or`)
+- **Clarity**: Use parentheses when in doubt for readability
+
 ### Markdown Documentation
 
 - **Linting**: Follow [markdownlint](https://github.com/DavidAnson/markdownlint) conventions

bin/torrust-deploy

@@ -1,9 +1,7 @@
 #!/usr/bin/env perl
 
-# Set up Perl environment with safety features
-use strict;                  # Enable strict mode - catches common programming errors like undeclared variables
-use warnings;                # Enable warnings - shows potential issues in the code
-use v5.20;                   # Require Perl version 5.20 or higher for modern language features
+# Set up Perl environment with modern features (includes strict and warnings)
+use v5.40;
 
 # Configure module loading
 use FindBin qw($Bin);        # Import FindBin module and get $Bin variable containing this script's directory

lib/TorrustDeploy/App.pm

@@ -1,8 +1,6 @@
 package TorrustDeploy::App;
 
-use strict;
-use warnings;
-use v5.20;
+use v5.40;
 
 # App::Cmd framework setup - automatically discovers commands in TorrustDeploy::App::Command::*
 # Commands are found by convention: each .pm file in lib/TorrustDeploy/App/Command/ 

lib/TorrustDeploy/App/Command/provision.pm renamed to lib/TorrustDeploy/App/Command/Provision.pm

@@ -1,8 +1,6 @@
-package TorrustDeploy::App::Command::provision;
+package TorrustDeploy::App::Command::Provision;
 
-use strict;
-use warnings;
-use v5.20;
+use v5.40;
 
 use TorrustDeploy::App -command;
 use TorrustDeploy::Provision::OpenTofu;
@@ -64,9 +62,6 @@ sub execute {
 
     # Show final summary
     $self->_show_final_summary($vm_ip);
-    
-    say "Provisioning completed successfully!";
-    say "VM is ready at IP: $vm_ip";
 }
 
 sub _copy_templates {
@@ -244,7 +239,7 @@ __END__
 
 =head1 NAME
 
-TorrustDeploy::App::Command::provision - Provision Torrust Tracker VM
+TorrustDeploy::App::Command::Provision - Provision Torrust Tracker VM
 
 =head1 DESCRIPTION
 

lib/TorrustDeploy/Provision/OpenTofu.pm

@@ -1,8 +1,6 @@
 package TorrustDeploy::Provision::OpenTofu;
 
-use strict;
-use warnings;
-use v5.20;
+use v5.40;
 
 use JSON;
 
@@ -71,6 +69,7 @@ sub apply {
         die "OpenTofu apply failed with exit code: $result";
     }
 
+    say "";
     say "OpenTofu apply completed successfully.";
 }
 

project-words.txt

@@ -19,6 +19,7 @@ Mlocal
 netdev
 NOPASSWD
 opentofu
+perlstyle
 plugdev
 pwauth
 qcow

t/command/provision.t

@@ -4,19 +4,19 @@ use lib "$Bin/../../lib";
 use Path::Tiny qw(path);
 use File::Temp qw(tempdir);
 
-use TorrustDeploy::App::Command::provision;
+use TorrustDeploy::App::Command::Provision;
 use TorrustDeploy::App;
 
 subtest 'Provision command module loads correctly' => sub {
-    ok(TorrustDeploy::App::Command::provision->can('execute'), 'Provision command has execute method');
-    ok(TorrustDeploy::App::Command::provision->can('abstract'), 'Provision command has abstract method');
-    ok(TorrustDeploy::App::Command::provision->can('description'), 'Provision command has description method');
+    ok(TorrustDeploy::App::Command::Provision->can('execute'), 'Provision command has execute method');
+    ok(TorrustDeploy::App::Command::Provision->can('abstract'), 'Provision command has abstract method');
+    ok(TorrustDeploy::App::Command::Provision->can('description'), 'Provision command has description method');
 };
 
 subtest 'Provision command provides correct metadata' => sub {
-    is(TorrustDeploy::App::Command::provision->abstract, 'Provision Torrust Tracker VM using OpenTofu', 'Correct abstract');
+    is(TorrustDeploy::App::Command::Provision->abstract, 'Provision Torrust Tracker VM using OpenTofu', 'Correct abstract');
 
-    my $description = TorrustDeploy::App::Command::provision->description;
+    my $description = TorrustDeploy::App::Command::Provision->description;
     like($description, qr/Provision a Torrust Tracker virtual machine/, 'Description mentions VM provisioning');
     like($description, qr/OpenTofu/, 'Description mentions OpenTofu');
     like($description, qr/libvirt/, 'Description mentions libvirt');
@@ -71,7 +71,7 @@ subtest 'Provision command template copying functionality' => sub {
 
     # Create a mock provision command instance
     my $app = TorrustDeploy::App->new;
-    my $provision_cmd = TorrustDeploy::App::Command::provision->new({
+    my $provision_cmd = TorrustDeploy::App::Command::Provision->new({
         app => $app,
     });
 
@@ -109,7 +109,7 @@ subtest 'Provision command template copying functionality' => sub {
 
 subtest 'Provision command internal methods' => sub {
     my $app = TorrustDeploy::App->new;
-    my $provision_cmd = TorrustDeploy::App::Command::provision->new({
+    my $provision_cmd = TorrustDeploy::App::Command::Provision->new({
         app => $app,
     });