add/update tests

Author: sbc100

src/filelock/_unix.py

@@ -38,9 +38,7 @@ class UnixFileLock(BaseFileLock):
 
         def _acquire(self) -> None:
             ensure_directory_exists(self.lock_file)
-            open_flags = os.O_RDWR | os.O_TRUNC
-            if not Path(self.lock_file).exists():
-                open_flags |= os.O_CREAT
+            open_flags = os.O_RDWR | os.O_TRUNC | os.O_CREAT
             fd = os.open(self.lock_file, open_flags, self._context.mode)
             with suppress(PermissionError):  # This locked is not owned by this UID
                 os.fchmod(fd, self._context.mode)

tests/test_filelock.py

@@ -19,6 +19,7 @@
 import pytest
 
 from filelock import BaseFileLock, FileLock, SoftFileLock, Timeout, UnixFileLock, WindowsFileLock
+import filelock
 
 if TYPE_CHECKING:
     from collections.abc import Iterator
@@ -814,3 +815,12 @@ def __init__(self, file_path: str) -> None:
     lock_path = tmp_path / "a"
     lock = FilePathLock(str(lock_path))
     assert lock.lock_file == str(lock_path) + ".lock"
+
+
+@pytest.mark.parametrize("lock_type", [FileLock, SoftFileLock])
+def test_lock_is_removed(tmp_path: Path, lock_type: type[BaseFileLock]) -> None:
+    lock_path = tmp_path / "test.lock"
+    lock = lock_type(lock_path)
+    with lock:
+        assert Path.exists(lock_path)
+    assert not Path.exists(lock_path)