refactor: Add unapplied code and check empty item.

Author: toxicity188

api/src/main/java/kr/toxicity/model/api/bone/RenderedBone.java

@@ -138,6 +138,7 @@ public boolean createHitBox(@NotNull EntityAdapter entity, @NotNull Predicate<Re
     public boolean enchant(@NotNull BonePredicate predicate, boolean enchant) {
         if (predicate.test(this)) {
             itemStack = itemStack.modify(i -> {
+                if (i.isEmpty()) return i;
                 var meta = i.getItemMeta();
                 if (enchant) {
                     meta.addEnchant(Enchantment.UNBREAKING, 0, true);

api/src/main/java/kr/toxicity/model/api/util/TransformedItemStack.java

@@ -59,10 +59,7 @@ public record TransformedItemStack(@NotNull Vector3f offset, @NotNull Vector3f s
      * @return is air
      */
     public boolean isEmpty() {
-        return switch (itemStack.getType()) {
-            case AIR, CAVE_AIR, VOID_AIR -> true;
-            default -> false;
-        };
+        return itemStack.isEmpty();
     }
 
     /**

api/src/main/java/kr/toxicity/model/api/version/MinecraftVersion.java

@@ -70,14 +70,14 @@ public int compareTo(@NotNull MinecraftVersion o) {
 
     /**
      * Parses version from string
-     * @param version version like "1.21.4"
+     * @param version version like "1.21.5"
      */
     public MinecraftVersion(@NotNull String version) {
         this(version.split("\\."));
     }
     /**
      * Parses version from string array
-     * @param version version array like ["1", "21", "4"]
+     * @param version version array like ["1", "21", "5"]
      */
     public MinecraftVersion(@NotNull String[] version) {
         this(

nms/v1_21_R3/src/main/kotlin/kr/toxicity/model/nms/v1_21_R3/NMSImpl.kt

@@ -4,7 +4,6 @@ import ca.spottedleaf.moonrise.patches.chunk_system.level.entity.EntityLookup
 import com.google.gson.JsonParser
 import com.mojang.authlib.GameProfile
 import com.mojang.datafixers.util.Pair
-import io.netty.buffer.Unpooled
 import io.netty.channel.ChannelDuplexHandler
 import io.netty.channel.ChannelHandlerContext
 import io.netty.channel.ChannelPromise
@@ -17,7 +16,6 @@ import kr.toxicity.model.api.tracker.ModelRotation
 import kr.toxicity.model.api.tracker.Tracker
 import net.minecraft.core.component.DataComponents
 import net.minecraft.network.Connection
-import net.minecraft.network.FriendlyByteBuf
 import net.minecraft.network.protocol.Packet
 import net.minecraft.network.protocol.game.*
 import net.minecraft.network.syncher.EntityDataAccessor
@@ -296,13 +294,12 @@ class NMSImpl : NMS {
     private fun EntityTracker.mountPacket(entity: Entity = adapter.handle() as Entity, array: IntArray = entity.passengers.map {
         it.id
     }.toIntArray()): ClientboundSetPassengersPacket {
-        val buffer = FriendlyByteBuf(Unpooled.buffer())
-        buffer.writeVarInt(entity.id)
-        buffer.writeVarIntArray((displays().mapNotNull {
-            (it as? ModelDisplayImpl)?.display?.id
-        }.toIntArray() + array))
-        return ClientboundSetPassengersPacket.STREAM_CODEC.decode(buffer).apply {
-            buffer.release()
+        return useByteBuf { buffer ->
+            buffer.writeVarInt(entity.id)
+            buffer.writeVarIntArray((displays().mapNotNull {
+                (it as? ModelDisplayImpl)?.display?.id
+            }.toIntArray() + array))
+            ClientboundSetPassengersPacket.STREAM_CODEC.decode(buffer)
         }
     }
 
@@ -477,6 +474,7 @@ class NMSImpl : NMS {
         )
 
     override fun tint(itemStack: ItemStack, rgb: Int): ItemStack {
+        if (itemStack.isEmpty) return itemStack
         return CraftItemStack.asBukkitCopy(CraftItemStack.asNMSCopy(itemStack).apply {
             set(DataComponents.DYED_COLOR, DyedItemColor(rgb, false))
             set(DataComponents.CUSTOM_MODEL_DATA, get(DataComponents.CUSTOM_MODEL_DATA)?.let {

nms/v1_21_R4/src/main/kotlin/kr/toxicity/model/nms/v1_21_R4/NMSImpl.kt

@@ -4,7 +4,6 @@ import ca.spottedleaf.moonrise.patches.chunk_system.level.entity.EntityLookup
 import com.google.gson.JsonParser
 import com.mojang.authlib.GameProfile
 import com.mojang.datafixers.util.Pair
-import io.netty.buffer.Unpooled
 import io.netty.channel.ChannelDuplexHandler
 import io.netty.channel.ChannelHandlerContext
 import io.netty.channel.ChannelPromise
@@ -17,7 +16,6 @@ import kr.toxicity.model.api.tracker.ModelRotation
 import kr.toxicity.model.api.tracker.Tracker
 import net.minecraft.core.component.DataComponents
 import net.minecraft.network.Connection
-import net.minecraft.network.FriendlyByteBuf
 import net.minecraft.network.protocol.Packet
 import net.minecraft.network.protocol.game.*
 import net.minecraft.network.syncher.EntityDataAccessor
@@ -296,13 +294,12 @@ class NMSImpl : NMS {
     private fun EntityTracker.mountPacket(entity: Entity = adapter.handle() as Entity, array: IntArray = entity.passengers.map {
         it.id
     }.toIntArray()): ClientboundSetPassengersPacket {
-        val buffer = FriendlyByteBuf(Unpooled.buffer())
-        buffer.writeVarInt(entity.id)
-        buffer.writeVarIntArray((displays().mapNotNull {
-            (it as? ModelDisplayImpl)?.display?.id
-        }.toIntArray() + array))
-        return ClientboundSetPassengersPacket.STREAM_CODEC.decode(buffer).apply {
-            buffer.release()
+        return useByteBuf { buffer ->
+            buffer.writeVarInt(entity.id)
+            buffer.writeVarIntArray((displays().mapNotNull {
+                (it as? ModelDisplayImpl)?.display?.id
+            }.toIntArray() + array))
+            ClientboundSetPassengersPacket.STREAM_CODEC.decode(buffer)
         }
     }
 
@@ -477,6 +474,7 @@ class NMSImpl : NMS {
         )
 
     override fun tint(itemStack: ItemStack, rgb: Int): ItemStack {
+        if (itemStack.isEmpty) return itemStack
         return CraftItemStack.asBukkitCopy(CraftItemStack.asNMSCopy(itemStack).apply {
             set(DataComponents.DYED_COLOR, DyedItemColor(rgb))
             set(DataComponents.CUSTOM_MODEL_DATA, get(DataComponents.CUSTOM_MODEL_DATA)?.let {