Skip to content

Commit b12db6e

Browse files
committed
feat: exclude fleet key
1 parent d409801 commit b12db6e

2 files changed

Lines changed: 13 additions & 5 deletions

File tree

crates/burn-central-fleet/src/telemetry/inference.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ pub fn record_request(data: RequestTelemetry) {
5555
"inference_name" => data.inference_name.clone(),
5656
"model_name" => data.model_name.clone(),
5757
"model_version" => data.model_version.clone(),
58-
"fleet_key" => data.fleet_key.clone(),
5958
"cancelled" => cancelled.clone(),
6059
)
6160
.increment(1);
@@ -65,7 +64,6 @@ pub fn record_request(data: RequestTelemetry) {
6564
"inference_name" => data.inference_name.clone(),
6665
"model_name" => data.model_name.clone(),
6766
"model_version" => data.model_version.clone(),
68-
"fleet_key" => data.fleet_key.clone(),
6967
)
7068
.increment(data.outputs as u64);
7169

@@ -74,7 +72,6 @@ pub fn record_request(data: RequestTelemetry) {
7472
"inference_name" => data.inference_name.clone(),
7573
"model_name" => data.model_name.clone(),
7674
"model_version" => data.model_version.clone(),
77-
"fleet_key" => data.fleet_key.clone(),
7875
)
7976
.increment(data.errors as u64);
8077

@@ -83,7 +80,6 @@ pub fn record_request(data: RequestTelemetry) {
8380
"inference_name" => data.inference_name.clone(),
8481
"model_name" => data.model_name.clone(),
8582
"model_version" => data.model_version.clone(),
86-
"fleet_key" => data.fleet_key.clone(),
8783
"cancelled" => cancelled,
8884
)
8985
.record(duration_ms);

crates/burn-central-fleet/src/telemetry/mod.rs

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,23 @@ where
7272
metrics_tracing_context::MetricsLayer::new()
7373
}
7474

75+
/// Label filter that excludes internal fleet metadata fields from being promoted to metric labels.
76+
/// Users can still add their own span fields and they will be included as metric labels.
77+
#[derive(Clone)]
78+
struct FleetLabelFilter;
79+
80+
impl metrics_tracing_context::LabelFilter for FleetLabelFilter {
81+
fn should_include_label(&self, _name: &::metrics::KeyName, label: &::metrics::Label) -> bool {
82+
!matches!(label.key(), "fleet_key")
83+
}
84+
}
85+
7586
/// Creates a metrics recorder that inherits tracing context from the current span.
7687
/// Required for metrics to inherit tracing labels.
7788
pub fn metrics_recorder() -> impl ::metrics::Recorder {
7889
let global_recorder = GLOBAL_RECORDER.get_or_init(InMemoryMetricsRecorder::new);
79-
metrics_tracing_context::TracingContextLayer::all().layer(global_recorder.clone())
90+
metrics_tracing_context::TracingContextLayer::new(FleetLabelFilter)
91+
.layer(global_recorder.clone())
8092
}
8193

8294
/// Creates a tracing layer that captures tracing events into fleet telemetry logs.

0 commit comments

Comments
 (0)