Fix ARM64 crash reproduction and helper.py patching #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tracer bot failed to reproduce crashes on ARM64 due to incorrect parameter passing in the reproduce_impl patch. The err_result value was being passed as a positional argument to docker_run(), which interpreted it as print_output=False, redirecting all output to /dev/null. Changes: - Fix reproduce_impl to pass architecture as keyword arg only - Refactor ARM64 patching into separate dockerfile and runner functions - Add comprehensive helper.py patching for ARM64: * Patch image_name variables to use :manifest-arm64v8 tag * Patch BASE_RUNNER_IMAGE assignment with tag stripping * Fix debug mode tag insertion (insert -debug before tag, not after) * Prevent double-tagging in _get_base_runner_image() - Default CLI architecture parameters to ARCHITECTURE constant This enables the tracer bot to see fuzzer output and successfully detect crash reproduction on ARM64 systems.
Collaborator
Author
|
|
Collaborator
|
Oops, I forgot to mention this last time we talked indeed: google/oss-fuzz#14178 |
Collaborator
|
Seems to be working for me! How did it go on your end @hbrodin ? |
Collaborator
Author
|
I've successfully run it so I think it works. Sorry, forgot to update the issue 🫣 . |
ret2libc
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tracer bot failed to reproduce crashes on ARM64 due to incorrect parameter passing in the reproduce_impl patch. The err_result value was being passed as a positional argument to docker_run(), which interpreted it as print_output=False, redirecting all output to /dev/null.
Changes:
This enables the tracer bot to see fuzzer output and successfully detect crash reproduction on ARM64 systems.