Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: no implicit conversion of nil into String #905

Open
irees opened this issue Dec 25, 2016 · 3 comments
Open

TypeError: no implicit conversion of nil into String #905

irees opened this issue Dec 25, 2016 · 3 comments
Assignees
Labels

Comments

@irees
Copy link
Member

irees commented Dec 25, 2016

https://sentry.io/mapzen/datastore-prod/issues/195808529/

TypeError: no implicit conversion of nil into String
  app/services/feed_fetcher_service.rb:151:in `read_gtfs_info'
    start_date, end_date = gtfs.service_period_range
  app/services/feed_fetcher_service.rb:144:in `fetch_and_normalize_feed_version'
    data = data.merge!(read_gtfs_info(gtfs))
  app/services/feed_fetcher_service.rb:54:in `fetch_and_return_feed_version'
    feed_version = fetch_and_normalize_feed_version(feed)
  app/workers/feed_fetcher_worker.rb:11:in `perform'
    feed_version = FeedFetcherService.fetch_and_return_feed_version(feed)
...
(36 additional frame(s) were not displayed)

TypeError: no implicit conversion of nil into String
@irees irees self-assigned this Dec 25, 2016
@drewda drewda added the bug label Jan 5, 2017
@drewda
Copy link
Member

drewda commented Aug 2, 2017

@drewda
Copy link
Member

drewda commented Aug 2, 2017

@drewda
Copy link
Member

drewda commented Aug 2, 2017

One instance of this happening:

The zip file that is currently served includes many empty files:

screen shot 2017-08-02 at 4 30 09 pm

I've just contacted CART to see if they have a current GTFS feed at a new location.

We may also want to consider throwing a more descriptive error about missing calendars in the future -- as well as catching it more gracefully, so it doesn't have to go all the way to Sentry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants