No need to alter properties in dealloc

Coeur · Coeur · commit 7b2ce2c97656 · 2023-12-29T03:54:37.000+01:00
diff --git a/macosx/VDKQueue/VDKQueue.mm b/macosx/VDKQueue/VDKQueue.mm
@@ -39,8 +39,8 @@
 /// This is a simple model class used to hold info about each path we watch.
 @interface VDKQueuePathEntry : NSObject
 
-@property(atomic, copy) NSString* path;
-@property(atomic, assign) int watchedFD;
+@property(atomic, copy, readonly) NSString* path;
+@property(atomic, assign, readonly) int watchedFD;
 @property(atomic, assign) u_int subscriptionFlags;
 
 @end
@@ -69,7 +69,6 @@ - (void)dealloc
     {
         close(_watchedFD);
     }
-    _watchedFD = -1;
 }
 
 @end

Original file line number	Diff line number	Diff line change
`@@ -39,8 +39,8 @@`
`39`	`39`	`/// This is a simple model class used to hold info about each path we watch.`
`40`	`40`	`@interface VDKQueuePathEntry : NSObject`
`41`	`41`
`42`		`-@property(atomic, copy) NSString* path;`
`43`		`-@property(atomic, assign) int watchedFD;`
	`42`	`+@property(atomic, copy, readonly) NSString* path;`
	`43`	`+@property(atomic, assign, readonly) int watchedFD;`
`44`	`44`	`@property(atomic, assign) u_int subscriptionFlags;`
`45`	`45`
`46`	`46`	`@end`
`@@ -69,7 +69,6 @@ - (void)dealloc`
`69`	`69`	`{`
`70`	`70`	`close(_watchedFD);`
`71`	`71`	`}`
`72`		`- _watchedFD = -1;`
`73`	`72`	`}`
`74`	`73`
`75`	`74`	`@end`